Expose JS Responder handler in Scheduler API

Summary: This diff implements the JSResponderHandler methods in the core of RN (scheduler API and friends)

Reviewed By: ejanzer

Differential Revision: D16543437

fbshipit-source-id: dac03e30c4330d182ecf134f3174ba942dbf7289

Author: mdvacca

React/Fabric/RNScheduler.mm

@@ -43,6 +43,20 @@ void schedulerDidDispatchCommand(
     [scheduler.delegate schedulerDidDispatchCommand:shadowView commandName:commandName args:args];
   }
 
+  void schedulerDidSetJSResponder(
+      SurfaceId surfaceId,
+      const ShadowView &shadowView,
+      const ShadowView &initialShadowView,
+      bool blockNativeResponder) override
+  {
+    // Does nothing for now.
+  }
+
+  void schedulerDidClearJSResponder() override
+  {
+    // Does nothing for now.
+  }
+
  private:
   void *scheduler_;
 };

ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.cpp

@@ -724,6 +724,14 @@ void Binding::schedulerDidDispatchCommand(
   dispatchCommand(localJavaUIManager, shadowView.tag, command.get(), argsArray.get());
 }
 
+void Binding::schedulerDidSetJSResponder(
+    SurfaceId surfaceId,
+    const ShadowView &shadowView,
+    const ShadowView &initialShadowView,
+    bool blockNativeResponder) { }
+
+void Binding::schedulerDidClearJSResponder() { }
+
 void Binding::registerNatives() {
   registerHybrid(
       {makeNativeMethod("initHybrid", Binding::initHybrid),

ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.h

@@ -89,6 +89,14 @@ class Binding : public jni::HybridClass<Binding>, public SchedulerDelegate {
 
   void setPixelDensity(float pointScaleFactor);
 
+  void schedulerDidSetJSResponder(
+     SurfaceId surfaceId,
+     const ShadowView &shadowView,
+     const ShadowView &initialShadowView,
+     bool blockNativeResponder);
+
+  void schedulerDidClearJSResponder();
+
   void uninstallFabricUIManager();
 };
 

ReactCommon/fabric/uimanager/Scheduler.cpp

@@ -274,5 +274,30 @@ void Scheduler::uiManagerDidDispatchCommand(
   }
 }
 
+/*
+ * Set JS responder for a view
+ */
+void Scheduler::uiManagerDidSetJSResponder(
+    SurfaceId surfaceId,
+    const SharedShadowNode &shadowNode,
+    bool blockNativeResponder) {
+  if (delegate_) {
+    // TODO: the first shadowView paramenter, should be the first parent that
+    // is non virtual.
+    auto shadowView = ShadowView(*shadowNode);
+    delegate_->schedulerDidSetJSResponder(
+        surfaceId, shadowView, shadowView, blockNativeResponder);
+  }
+}
+
+/*
+ * Clear the JSResponder for a view
+ */
+void Scheduler::uiManagerDidClearJSResponder() {
+  if (delegate_) {
+    delegate_->schedulerDidClearJSResponder();
+  }
+}
+
 } // namespace react
 } // namespace facebook

ReactCommon/fabric/uimanager/Scheduler.h

@@ -90,6 +90,11 @@ class Scheduler final : public UIManagerDelegate, public ShadowTreeDelegate {
       const SharedShadowNode &shadowNode,
       std::string const &commandName,
       folly::dynamic const args) override;
+  void uiManagerDidSetJSResponder(
+      SurfaceId surfaceId,
+      const SharedShadowNode &shadowView,
+      bool blockNativeResponder) override;
+  void uiManagerDidClearJSResponder() override;
 
 #pragma mark - ShadowTreeDelegate
 

ReactCommon/fabric/uimanager/SchedulerDelegate.h

@@ -40,6 +40,20 @@ class SchedulerDelegate {
       std::string const &commandName,
       folly::dynamic const args) = 0;
 
+  /*
+   * Set JS responder for a view
+   */
+  virtual void schedulerDidSetJSResponder(
+      SurfaceId surfaceId,
+      const ShadowView &shadowView,
+      const ShadowView &initialShadowView,
+      bool blockNativeResponder) = 0;
+
+  /*
+   * Clear the JSResponder for a view
+   */
+  virtual void schedulerDidClearJSResponder() = 0;
+
   virtual ~SchedulerDelegate() noexcept = default;
 };
 

ReactCommon/fabric/uimanager/UIManager.cpp

@@ -93,9 +93,18 @@ void UIManager::completeSurface(
 
 void UIManager::setJSResponder(
     const SharedShadowNode &shadowNode,
-    const bool blockNativeResponder) const {}
+    const bool blockNativeResponder) const {
+  if (delegate_) {
+    delegate_->uiManagerDidSetJSResponder(
+        shadowNode->getSurfaceId(), shadowNode, blockNativeResponder);
+  }
+}
 
-void UIManager::clearJSResponder() const {}
+void UIManager::clearJSResponder() const {
+  if (delegate_) {
+    delegate_->uiManagerDidClearJSResponder();
+  }
+}
 
 void UIManager::setNativeProps(
     const SharedShadowNode &shadowNode,

ReactCommon/fabric/uimanager/UIManagerDelegate.h

@@ -42,6 +42,19 @@ class UIManagerDelegate {
       std::string const &commandName,
       folly::dynamic const args) = 0;
 
+  /*
+   * Set JS responder for a view
+   */
+  virtual void uiManagerDidSetJSResponder(
+      SurfaceId surfaceId,
+      SharedShadowNode const &shadowView,
+      bool blockNativeResponder) = 0;
+
+  /*
+   * Clear the JSResponder for a view
+   */
+  virtual void uiManagerDidClearJSResponder() = 0;
+
   virtual ~UIManagerDelegate() noexcept = default;
 };