Skip to content

Commit 0baac1c

Browse files
sherginfacebook-github-bot
authored andcommitted
Fabric: Improvements in Diffing test (messWithLayotableOnlyFlag)
Summary: Now we tweak more props in order to prepare for new flattening algorithm. Changelog: [Internal] Fabric-specific internal change. Reviewed By: JoshuaGross Differential Revision: D20212254 fbshipit-source-id: 7391155072f93046e78fbecf4bb4b42cb1caacdc
1 parent 903bf2d commit 0baac1c

File tree

1 file changed

+41
-8
lines changed

1 file changed

+41
-8
lines changed

ReactCommon/fabric/mounting/tests/shadowTreeGeneration.h

Lines changed: 41 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -119,17 +119,50 @@ static ShadowNode::Unshared messWithChildren(
119119
static ShadowNode::Unshared messWithLayotableOnlyFlag(
120120
Entropy const &entropy,
121121
ShadowNode const &shadowNode) {
122-
folly::dynamic dynamic = folly::dynamic::object();
122+
auto oldProps = shadowNode.getProps();
123+
auto newProps = shadowNode.getComponentDescriptor().cloneProps(
124+
oldProps, RawProps(folly::dynamic::object()));
123125

124-
if (entropy.random<bool>()) {
125-
dynamic["collapsable"] = folly::dynamic{true};
126-
} else {
127-
dynamic["collapsable"] = folly::dynamic{};
126+
auto &viewProps =
127+
const_cast<ViewProps &>(static_cast<ViewProps const &>(*newProps));
128+
129+
if (entropy.random<bool>(0.1)) {
130+
viewProps.nativeId = entropy.random<bool>() ? "42" : "";
131+
}
132+
133+
if (entropy.random<bool>(0.1)) {
134+
viewProps.backgroundColor =
135+
entropy.random<bool>() ? SharedColor() : whiteColor();
136+
}
137+
138+
if (entropy.random<bool>(0.1)) {
139+
viewProps.foregroundColor =
140+
entropy.random<bool>() ? SharedColor() : blackColor();
141+
}
142+
143+
if (entropy.random<bool>(0.1)) {
144+
viewProps.shadowColor =
145+
entropy.random<bool>() ? SharedColor() : blackColor();
146+
}
147+
148+
if (entropy.random<bool>(0.1)) {
149+
viewProps.accessible = entropy.random<bool>();
150+
}
151+
152+
if (entropy.random<bool>(0.1)) {
153+
viewProps.zIndex = entropy.random<bool>() ? 1 : 0;
154+
}
155+
156+
if (entropy.random<bool>(0.1)) {
157+
viewProps.pointerEvents = entropy.random<bool>() ? PointerEventsMode::Auto
158+
: PointerEventsMode::None;
159+
}
160+
161+
if (entropy.random<bool>(0.1)) {
162+
viewProps.transform = entropy.random<bool>() ? Transform::Identity()
163+
: Transform::Perspective(42);
128164
}
129165

130-
auto oldProps = shadowNode.getProps();
131-
auto newProps = shadowNode.getComponentDescriptor().cloneProps(
132-
oldProps, RawProps(dynamic));
133166
return shadowNode.clone({newProps});
134167
}
135168

0 commit comments

Comments
 (0)