Skip to content

Commit 0c90ab4

Browse files
davidaurelioFacebook Github Bot 7
authored andcommitted
Add Random Access Module file names to stack traces
Reviewed By: javache Differential Revision: D3269450 fb-gh-sync-id: 41b2013d4422c2bcafa7628321d4626fd40aac5d fbshipit-source-id: 41b2013d4422c2bcafa7628321d4626fd40aac5d
1 parent 097f591 commit 0c90ab4

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

React/Base/RCTAssert.m

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,19 @@ RCTFatalHandler RCTGetFatalHandler(void)
156156
NSMutableString *prettyStack = [NSMutableString string];
157157
if (stackTrace) {
158158
[prettyStack appendString:@", stack:\n"];
159+
160+
NSRegularExpression *regex = [NSRegularExpression regularExpressionWithPattern:@"^(\\d+\\.js)$"
161+
options:NSRegularExpressionCaseInsensitive
162+
error:NULL];
159163
for (NSDictionary<NSString *, id> *frame in stackTrace) {
160-
[prettyStack appendFormat:@"%@@%@:%@\n", frame[@"methodName"], frame[@"lineNumber"], frame[@"column"]];
164+
NSString *fileName = [frame[@"file"] lastPathComponent];
165+
if (fileName && [regex numberOfMatchesInString:fileName options:0 range:NSMakeRange(0, [fileName length])]) {
166+
fileName = [fileName stringByAppendingString:@":"];
167+
} else {
168+
fileName = @"";
169+
}
170+
171+
[prettyStack appendFormat:@"%@@%@%@:%@\n", frame[@"methodName"], fileName, frame[@"lineNumber"], frame[@"column"]];
161172
}
162173
}
163174

0 commit comments

Comments
 (0)