Skip to content

Commit 1433d15

Browse files
ttsugriyfacebook-github-bot
ttsugriy
authored and
facebook-github-bot
committed
Avoid top-level read_config invocations.
Reviewed By: danzimm Differential Revision: D7651745 fbshipit-source-id: 5cbc82b3c9da3ab514278d438f97f98e19946dc7
1 parent b5f90ed commit 1433d15

File tree

7 files changed

+16
-16
lines changed

7 files changed

+16
-16
lines changed

‎ReactCommon/cxxreact/BUCK‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
load("@xplat//configurations/buck/apple:flag_defs.bzl", "get_debug_preprocessor_flags")
2-
load("//ReactNative:DEFS.bzl", "IS_OSS_BUILD", "rn_xplat_cxx_library", "ANDROID_INSPECTOR_FLAGS", "APPLE_INSPECTOR_FLAGS", "ANDROID_JSC_DEPS", "APPLE_JSC_DEPS", "react_native_xplat_target")
2+
load("//ReactNative:DEFS.bzl", "IS_OSS_BUILD", "rn_xplat_cxx_library", "get_android_inspector_flags", "get_apple_inspector_flags", "ANDROID_JSC_DEPS", "APPLE_JSC_DEPS", "react_native_xplat_target")
33

44
CXX_LIBRARY_COMPILER_FLAGS = [
55
"-std=c++14",
@@ -129,7 +129,7 @@ rn_xplat_cxx_library(
129129
"-frtti",
130130
],
131131
fbandroid_deps = ANDROID_JSC_DEPS,
132-
fbandroid_preprocessor_flags = ANDROID_INSPECTOR_FLAGS + [
132+
fbandroid_preprocessor_flags = get_android_inspector_flags() + [
133133
"-DWITH_JSC_EXTRA_TRACING=1",
134134
"-DWITH_JSC_MEMORY_PRESSURE=1",
135135
"-DWITH_FB_MEMORY_PROFILING=1",
@@ -139,7 +139,7 @@ rn_xplat_cxx_library(
139139
fbobjc_frameworks = [
140140
"$SDKROOT/System/Library/Frameworks/JavaScriptCore.framework",
141141
],
142-
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + APPLE_INSPECTOR_FLAGS,
142+
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
143143
force_static = True,
144144
macosx_tests_override = [],
145145
platforms = (ANDROID, APPLE),

‎ReactCommon/exceptions/BUCK‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
load("//configurations/buck/apple:flag_defs.bzl", "get_debug_preprocessor_flags")
2-
load("//ReactNative:DEFS.bzl", "IS_OSS_BUILD", "react_native_xplat_target", "rn_xplat_cxx_library", "APPLE_INSPECTOR_FLAGS")
2+
load("//ReactNative:DEFS.bzl", "IS_OSS_BUILD", "react_native_xplat_target", "rn_xplat_cxx_library", "get_apple_inspector_flags")
33

44
APPLE_COMPILER_FLAGS = []
55

@@ -24,7 +24,7 @@ rn_xplat_cxx_library(
2424
"-Wall",
2525
],
2626
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
27-
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + APPLE_INSPECTOR_FLAGS,
27+
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
2828
force_static = True,
2929
preprocessor_flags = [
3030
"-DLOG_TAG=\"ReactNative\"",

‎ReactCommon/fabric/core/BUCK‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
load("//configurations/buck/apple:flag_defs.bzl", "get_debug_preprocessor_flags")
2-
load("//ReactNative:DEFS.bzl", "IS_OSS_BUILD", "react_native_xplat_target", "rn_xplat_cxx_library", "APPLE_INSPECTOR_FLAGS")
2+
load("//ReactNative:DEFS.bzl", "IS_OSS_BUILD", "react_native_xplat_target", "rn_xplat_cxx_library", "get_apple_inspector_flags")
33

44
APPLE_COMPILER_FLAGS = []
55

@@ -34,16 +34,16 @@ rn_xplat_cxx_library(
3434
"-Wall",
3535
],
3636
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
37-
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + APPLE_INSPECTOR_FLAGS,
37+
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
3838
fbobjc_tests = [
3939
":tests",
4040
],
4141
force_static = True,
42+
macosx_tests_override = [],
4243
preprocessor_flags = [
4344
"-DLOG_TAG=\"ReactNative\"",
4445
"-DWITH_FBSYSTRACE=1",
4546
],
46-
macosx_tests_override = [],
4747
tests = [],
4848
visibility = ["PUBLIC"],
4949
deps = [

‎ReactCommon/fabric/debug/BUCK‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
load("@xplat//configurations/buck/apple:flag_defs.bzl", "get_debug_preprocessor_flags")
2-
load("//ReactNative:DEFS.bzl", "IS_OSS_BUILD", "react_native_xplat_target", "rn_xplat_cxx_library", "APPLE_INSPECTOR_FLAGS")
2+
load("//ReactNative:DEFS.bzl", "IS_OSS_BUILD", "react_native_xplat_target", "rn_xplat_cxx_library", "get_apple_inspector_flags")
33

44
APPLE_COMPILER_FLAGS = []
55

@@ -31,7 +31,7 @@ rn_xplat_cxx_library(
3131
"-Wall",
3232
],
3333
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
34-
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + APPLE_INSPECTOR_FLAGS,
34+
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
3535
fbobjc_tests = [
3636
":tests",
3737
],

‎ReactCommon/fabric/graphics/BUCK‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
load("//configurations/buck/apple:flag_defs.bzl", "get_debug_preprocessor_flags")
2-
load("//ReactNative:DEFS.bzl", "IS_OSS_BUILD", "react_native_xplat_target", "rn_xplat_cxx_library", "APPLE_INSPECTOR_FLAGS")
2+
load("//ReactNative:DEFS.bzl", "IS_OSS_BUILD", "react_native_xplat_target", "rn_xplat_cxx_library", "get_apple_inspector_flags")
33

44
APPLE_COMPILER_FLAGS = []
55

@@ -31,7 +31,7 @@ rn_xplat_cxx_library(
3131
"-frtti",
3232
],
3333
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
34-
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + APPLE_INSPECTOR_FLAGS,
34+
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
3535
fbobjc_tests = [
3636
":tests",
3737
],

‎ReactCommon/fabric/uimanager/BUCK‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
load("//configurations/buck/apple:flag_defs.bzl", "get_debug_preprocessor_flags")
2-
load("//ReactNative:DEFS.bzl", "IS_OSS_BUILD", "react_native_xplat_target", "rn_xplat_cxx_library", "APPLE_INSPECTOR_FLAGS")
2+
load("//ReactNative:DEFS.bzl", "IS_OSS_BUILD", "react_native_xplat_target", "rn_xplat_cxx_library", "get_apple_inspector_flags")
33

44
APPLE_COMPILER_FLAGS = []
55

@@ -31,7 +31,7 @@ rn_xplat_cxx_library(
3131
"-Wall",
3232
],
3333
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
34-
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + APPLE_INSPECTOR_FLAGS,
34+
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
3535
fbobjc_tests = [
3636
":tests",
3737
],

‎ReactCommon/fabric/view/BUCK‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
load("//configurations/buck/apple:flag_defs.bzl", "get_application_ios_flags", "get_debug_preprocessor_flags", "OBJC_ARC_PREPROCESSOR_FLAGS")
2-
load("//ReactNative:DEFS.bzl", "IS_OSS_BUILD", "rn_xplat_cxx_library", "APPLE_INSPECTOR_FLAGS")
2+
load("//ReactNative:DEFS.bzl", "IS_OSS_BUILD", "rn_xplat_cxx_library", "get_apple_inspector_flags")
33
load("//ReactNative:DEFS.bzl", "react_native_xplat_target")
44

55
APPLE_COMPILER_FLAGS = []
@@ -34,7 +34,7 @@ rn_xplat_cxx_library(
3434
"-Wall",
3535
],
3636
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
37-
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + APPLE_INSPECTOR_FLAGS,
37+
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
3838
fbobjc_tests = [
3939
":tests",
4040
],

0 commit comments

Comments
 (0)