Skip to content

Commit 1d1386e

Browse files
committed
Merge pull request facebook#1839 from a2/Update_Wed_1_Jul
Updates from Wed 1 Jul
2 parents 4e6f48c + 13be945 commit 1d1386e

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+272
-511
lines changed

.flowconfig

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@ suppress_type=$FlowIssue
4040
suppress_type=$FlowFixMe
4141
suppress_type=$FixMe
4242

43-
suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(1[0-2]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)
44-
suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(1[0-2]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)? #[0-9]+
43+
suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(1[0-3]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)
44+
suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(1[0-3]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)? #[0-9]+
4545
suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
4646

4747
[version]
48-
0.12.0
48+
0.13.1

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ install:
1515
- cp $(brew --prefix nvm)/nvm-exec .nvm/
1616
- export NVM_DIR=.nvm
1717
- source $(brew --prefix nvm)/nvm.sh
18-
- nvm install v0.10
18+
- nvm install iojs-v2
1919
- npm config set spin=false
2020
- npm install
2121

2222
script:
2323
- |
24-
nvm use v0.10
24+
nvm use iojs-v2
2525
2626
if [ "$TEST_TYPE" = objc ]
2727
then

Examples/Movies/SearchScreen.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ var {
2626
} = React;
2727
var TimerMixin = require('react-timer-mixin');
2828

29+
var invariant = require('invariant');
30+
2931
var MovieCell = require('./MovieCell');
3032
var MovieScreen = require('./MovieScreen');
3133

@@ -73,18 +75,16 @@ var SearchScreen = React.createClass({
7375
this.searchMovies('');
7476
},
7577

76-
_urlForQueryAndPage: function(query: string, pageNumber: ?number): string {
78+
_urlForQueryAndPage: function(query: string, pageNumber: number): string {
7779
var apiKey = API_KEYS[this.state.queryNumber % API_KEYS.length];
7880
if (query) {
7981
return (
80-
// $FlowFixMe(>=0.13.0) - pageNumber may be null or undefined
8182
API_URL + 'movies.json?apikey=' + apiKey + '&q=' +
8283
encodeURIComponent(query) + '&page_limit=20&page=' + pageNumber
8384
);
8485
} else {
8586
// With no query, load latest movies
8687
return (
87-
// $FlowFixMe(>=0.13.0) - pageNumber may be null or undefined
8888
API_URL + 'lists/movies/in_theaters.json?apikey=' + apiKey +
8989
'&page_limit=20&page=' + pageNumber
9090
);
@@ -176,6 +176,7 @@ var SearchScreen = React.createClass({
176176
});
177177

178178
var page = resultsCache.nextPageNumberForQuery[query];
179+
invariant(page != null, 'Next page number for "%s" is missing', query);
179180
fetch(this._urlForQueryAndPage(query, page))
180181
.then((response) => response.json())
181182
.catch((error) => {

Examples/SampleApp/_flowconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,4 +33,4 @@ node_modules/react-native/Libraries/react-native/react-native-interface.js
3333
module.system=haste
3434

3535
[version]
36-
0.12.0
36+
0.13.1

Examples/UIExplorer/ActionSheetIOSExample.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,12 @@
1717

1818
var React = require('react-native');
1919
var {
20+
ActionSheetIOS,
2021
StyleSheet,
2122
Text,
2223
View,
2324
} = React;
24-
var ActionSheetIOS = require('ActionSheetIOS');
25+
2526
var BUTTONS = [
2627
'Button Index: 0',
2728
'Button Index: 1',

Examples/UIExplorer/AdSupportIOSExample.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,9 @@
1515
*/
1616
'use strict';
1717

18-
var AdSupportIOS = require('AdSupportIOS');
19-
2018
var React = require('react-native');
2119
var {
20+
AdSupportIOS,
2221
StyleSheet,
2322
Text,
2423
View,

Examples/UIExplorer/MapViewExample.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
'use strict';
1717

1818
var React = require('react-native');
19-
var StyleSheet = require('StyleSheet');
2019
var {
2120
MapView,
21+
StyleSheet,
2222
Text,
2323
TextInput,
2424
View,

Examples/UIExplorer/TransformExample.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,14 @@
66
'use strict';
77

88
var React = require('React');
9+
var {
10+
StyleSheet,
11+
View,
12+
} = React;
913

10-
var StyleSheet = require('StyleSheet');
1114
var TimerMixin = require('react-timer-mixin');
12-
var UIExplorerBlock = require('UIExplorerBlock');
13-
var UIExplorerPage = require('UIExplorerPage');
14-
var View = require('View');
15+
var UIExplorerBlock = require('./UIExplorerBlock');
16+
var UIExplorerPage = require('./UIExplorerPage');
1517

1618
var TransformExample = React.createClass({
1719

Examples/UIExplorer/UIExplorerApp.android.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,16 @@
1717
'use strict';
1818

1919
var React = require('react-native');
20-
var Dimensions = require('Dimensions');
21-
var DrawerLayoutAndroid = require('DrawerLayoutAndroid');
22-
var ToolbarAndroid = require('ToolbarAndroid');
23-
var UIExplorerList = require('./UIExplorerList');
2420
var {
21+
Dimensions,
2522
StyleSheet,
2623
View,
2724
} = React;
25+
var UIExplorerList = require('./UIExplorerList');
26+
27+
// TODO: these should be exposed by the 'react-native' module.
28+
var DrawerLayoutAndroid = require('DrawerLayoutAndroid');
29+
var ToolbarAndroid = require('ToolbarAndroid');
2830

2931
var DRAWER_WIDTH_LEFT = 56;
3032

Examples/UIExplorer/UIExplorerList.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ var {
2121
ListView,
2222
PixelRatio,
2323
Platform,
24+
Settings,
2425
StyleSheet,
2526
Text,
2627
TextInput,
@@ -29,13 +30,20 @@ var {
2930
} = React;
3031

3132
var { TestModule } = React.addons;
32-
var Settings = require('Settings');
3333

3434
import type { ExampleModule } from 'ExampleTypes';
3535

3636
var createExamplePage = require('./createExamplePage');
3737

3838
var COMMON_COMPONENTS = [
39+
require('./ImageExample'),
40+
require('./ListViewExample'),
41+
require('./ListViewPagingExample'),
42+
require('./MapViewExample'),
43+
require('./Navigator/NavigatorExample'),
44+
require('./ScrollViewExample'),
45+
require('./TextInputExample'),
46+
require('./TouchableExample'),
3947
require('./ViewExample'),
4048
require('./WebViewExample'),
4149
];
@@ -51,23 +59,15 @@ if (Platform.OS === 'ios') {
5159
var COMPONENTS = COMMON_COMPONENTS.concat([
5260
require('./ActivityIndicatorIOSExample'),
5361
require('./DatePickerIOSExample'),
54-
require('./ImageExample'),
55-
require('./ListViewExample'),
56-
require('./ListViewPagingExample'),
57-
require('./MapViewExample'),
58-
require('./Navigator/NavigatorExample'),
5962
require('./NavigatorIOSColorsExample'),
6063
require('./NavigatorIOSExample'),
6164
require('./PickerIOSExample'),
6265
require('./ProgressViewIOSExample'),
63-
require('./ScrollViewExample'),
6466
require('./SegmentedControlIOSExample'),
6567
require('./SliderIOSExample'),
6668
require('./SwitchIOSExample'),
6769
require('./TabBarIOSExample'),
6870
require('./TextExample.ios'),
69-
require('./TextInputExample'),
70-
require('./TouchableExample'),
7171
]);
7272

7373
var APIS = COMMON_APIS.concat([

0 commit comments

Comments
 (0)