Eagerly initialize FrescoModule

ayc1 · facebook-github-bot · commit 251cbb387188 · 2018-08-29T10:03:26.000-07:00
Summary: It's unclear if this was a recent regression or not (too lazy to find out), but instrumentation tests are failing because FrescoModule is never initialized (see task for trace). Based on the initial introduction of this class (D2448321) it appears that FrescoModule was always intended to be initialized on startup. Let's eagerly init Fresco in that case.

Reviewed By: fkgozali

Differential Revision: D9556864

fbshipit-source-id: 0b670dec46f5087b3794330931ddf5d7782c8367
diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/fresco/FrescoModule.java b/ReactAndroid/src/main/java/com/facebook/react/modules/fresco/FrescoModule.java
@@ -37,7 +37,7 @@
  *
  * <p>Does not expose any methods to JavaScript code. For initialization and cleanup only.
  */
-@ReactModule(name = "FrescoModule")
+@ReactModule(name = "FrescoModule", needsEagerInit = true)
 public class FrescoModule extends ReactContextBaseJavaModule implements
     ModuleDataCleaner.Cleanable, LifecycleEventListener {
 

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@`
`37`	`37`	`*`
`38`	`38`	`* <p>Does not expose any methods to JavaScript code. For initialization and cleanup only.`
`39`	`39`	`*/`
`40`		`-@ReactModule(name = "FrescoModule")`
	`40`	`+@ReactModule(name = "FrescoModule", needsEagerInit = true)`
`41`	`41`	`public class FrescoModule extends ReactContextBaseJavaModule implements`
`42`	`42`	`ModuleDataCleaner.Cleanable, LifecycleEventListener {`
`43`	`43`