Skip to content

Commit 2992518

Browse files
mdvaccafacebook-github-bot
authored andcommitted
Deprecate UIManagerModule.removeSubviewsFromContainerWithID
Summary: The method UIManagerModule.removeSubviewsFromContainerWithID will not be part of fabric. This diff deprecates it to avoid future usage before the migration. This can not be removed, as it is currently used from React-VR Reviewed By: shergin Differential Revision: D16420687 fbshipit-source-id: a06810cabb434e35e5a371444114db2633a35a29
1 parent a863949 commit 2992518

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

React/Modules/RCTUIManager.m

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -670,6 +670,7 @@ - (RCTViewManagerUIBlock)uiBlockWithLayoutUpdateForRootView:(RCTRootShadowView *
670670
*/
671671
RCT_EXPORT_METHOD(removeSubviewsFromContainerWithID:(nonnull NSNumber *)containerID)
672672
{
673+
RCTLogWarn(@"RCTUIManager.removeSubviewsFromContainerWithID method is deprecated and it will not be implemented in newer versions of RN (Fabric) - T47686450");
673674
id<RCTComponent> container = _shadowViewRegistry[containerID];
674675
RCTAssert(container != nil, @"container view (for ID %@) not found", containerID);
675676

ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -558,8 +558,10 @@ public void replaceExistingNonRootView(int oldTag, int newTag) {
558558
* receipt. TODO: The method name is incorrect and will be renamed, #6033872
559559
*
560560
* @param containerTag the tag of the container for which the subviews must be removed
561+
* @deprecated This method will not be available in Fabric UIManager.
561562
*/
562563
@ReactMethod
564+
@Deprecated
563565
public void removeSubviewsFromContainerWithID(int containerTag) {
564566
mUIImplementation.removeSubviewsFromContainerWithID(containerTag);
565567
}

0 commit comments

Comments
 (0)