Fix making loadScriptFromString always synchronous

Kathy Gray · facebook-github-bot · commit 35b888dc1194 · 2017-05-25T16:47:06.000-07:00
Reviewed By: javache

Differential Revision: D5129620

fbshipit-source-id: a0ad5e2704fc38f4cdfe29187a2b59ba4b0ff61b
diff --git a/ReactCommon/cxxreact/Instance.cpp b/ReactCommon/cxxreact/Instance.cpp
@@ -80,7 +80,7 @@ void Instance::loadScriptFromString(std::unique_ptr<const JSBigString> string,
   if (loadSynchronously) {
     loadApplicationSync(nullptr, std::move(string), std::move(sourceURL));
   } else {
-    loadApplicationSync(nullptr, std::move(string), std::move(sourceURL));
+    loadApplication(nullptr, std::move(string), std::move(sourceURL));
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ void Instance::loadScriptFromString(std::unique_ptr<const JSBigString> string,`
`80`	`80`	`if (loadSynchronously) {`
`81`	`81`	`loadApplicationSync(nullptr, std::move(string), std::move(sourceURL));`
`82`	`82`	`} else {`
`83`		`- loadApplicationSync(nullptr, std::move(string), std::move(sourceURL));`
	`83`	`+ loadApplication(nullptr, std::move(string), std::move(sourceURL));`
`84`	`84`	`}`
`85`	`85`	`}`
`86`	`86`