NetInfo: try to solve crash with releasing _firstTimeReachability

Mehdi Mulani · kelset · commit 35c1c27bf6a4 · 2018-11-26T16:36:58.000Z
Summary: @public We're seeing a crash on line 191 when we do `CFRelease(self->_firstTimeReachability);`. My thinking is that there's a race condition between the deallocation coming from calling `getCurrentConnectivity` twice in a row and the callback coming back. Reviewed By: PeteTheHeat Differential Revision: D12982772 fbshipit-source-id: d3d882a074b67a5e547e7f480f561fcaf8d79ec4
diff --git a/Libraries/Network/RCTNetInfo.m b/Libraries/Network/RCTNetInfo.m
@@ -69,6 +69,13 @@ static void RCTReachabilityCallback(__unused SCNetworkReachabilityRef target, SC
   }
 }
 
+// We need RCTReachabilityCallback's and module methods to be called on the same thread so that we can have
+// guarantees about when we mess with the reachability callbacks.
+- (dispatch_queue_t)methodQueue
+{
+  return dispatch_get_main_queue();
+}
+
 #pragma mark - Lifecycle
 
 - (instancetype)initWithHost:(NSString *)host

Original file line number	Diff line number	Diff line change
`@@ -69,6 +69,13 @@ static void RCTReachabilityCallback(__unused SCNetworkReachabilityRef target, SC`
`69`	`69`	`}`
`70`	`70`	`}`
`71`	`71`
	`72`	`+// We need RCTReachabilityCallback's and module methods to be called on the same thread so that we can have`
	`73`	`+// guarantees about when we mess with the reachability callbacks.`
	`74`	`+- (dispatch_queue_t)methodQueue`
	`75`	`+{`
	`76`	`+ return dispatch_get_main_queue();`
	`77`	`+}`
	`78`	`+`
`72`	`79`	`#pragma mark - Lifecycle`
`73`	`80`
`74`	`81`	`- (instancetype)initWithHost:(NSString *)host`