Skip to content

Commit 3e89c3e

Browse files
majakfacebook-github-bot-4
authored andcommitted
removed coalescingKey from events (2/7)
Summary: This property was never used, so I'm removing it. public ___ //This diff is part of a larger stack. For high level overview what's going on jump to D2884593.// Reviewed By: javache Differential Revision: D2884587 fb-gh-sync-id: acd5e576cd13a02e77225f3b308232f8331d3b61
1 parent ee53303 commit 3e89c3e

File tree

4 files changed

+1
-10
lines changed

4 files changed

+1
-10
lines changed

Examples/UIExplorer/UIExplorerUnitTests/RCTEventDispatcherTests.m

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ @implementation RCTTestEvent
3030
@synthesize viewTag = _viewTag;
3131
@synthesize eventName = _eventName;
3232
@synthesize body = _body;
33-
@synthesize coalescingKey = _coalescingKey;
3433

3534
- (instancetype)initWithViewTag:(NSNumber *)viewTag eventName:(NSString *)eventName body:(NSDictionary<NSString *, id> *)body
3635
{

React/Base/RCTEventDispatcher.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ RCT_EXTERN NSString *RCTNormalizeInputEventName(NSString *eventName);
4949
@property (nonatomic, strong, readonly) NSNumber *viewTag;
5050
@property (nonatomic, copy, readonly) NSString *eventName;
5151
@property (nonatomic, copy, readonly) NSDictionary *body;
52-
@property (nonatomic, assign, readonly) uint16_t coalescingKey;
5352

5453
- (BOOL)canCoalesce;
5554
- (id<RCTEvent>)coalesceWithEvent:(id<RCTEvent>)newEvent;

React/Base/RCTEventDispatcher.m

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,7 @@
3030
{
3131
return @(
3232
event.viewTag.intValue |
33-
(((uint64_t)event.eventName.hash & 0xFFFF) << 32) |
34-
(((uint64_t)event.coalescingKey) << 48)
35-
);
33+
(((uint64_t)event.eventName.hash & 0xFFFF) << 32));
3634
}
3735

3836
@interface RCTEventDispatcher() <RCTFrameUpdateObserver>

React/Views/RCTScrollView.m

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,6 @@ - (instancetype)initWithType:(RCTScrollEventType)type
5959

6060
RCT_NOT_IMPLEMENTED(- (instancetype)init)
6161

62-
- (uint16_t)coalescingKey
63-
{
64-
return 0;
65-
}
66-
6762
- (NSDictionary *)body
6863
{
6964
NSDictionary *body = @{

0 commit comments

Comments
 (0)