Skip to content

Commit 4cda0df

Browse files
sherginfacebook-github-bot
authored andcommitted
Switching to the new FabricUIManager and all new shadow tree infra
Reviewed By: fkgozali Differential Revision: D7230670 fbshipit-source-id: bca7d2859b87931c0d15406782b7d689de1d8c36
1 parent c2ad59a commit 4cda0df

File tree

5 files changed

+13
-50
lines changed

5 files changed

+13
-50
lines changed

React/Fabric/RCTFabricPlatformUIOperationManager.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
#import <memory>
1212

13-
#include <fabric/IFabricPlatformUIOperationManager.h>
13+
#include <fabric/uimanager/IFabricPlatformUIOperationManager.h>
1414

1515
@class RCTFabricPlatformUIOperationManager;
1616

React/Fabric/RCTFabricUIManagerWrapper.mm

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,11 @@
77

88
#import "RCTFabricUIManagerWrapper.h"
99

10-
#include <fabric/FabricUIManager.h>
10+
#include <fabric/uimanager/FabricUIManager.h>
11+
12+
#include <folly/dynamic.h>
13+
#include <folly/json.h>
14+
1115

1216
#import "RCTFabricPlatformUIOperationManager.h"
1317

ReactCommon/fabric/BUCK

Lines changed: 0 additions & 46 deletions
This file was deleted.

ReactCommon/fabric/uimanager/BUCK

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ rn_xplat_cxx_library(
4646
"xplat//folly:memory",
4747
"xplat//folly:molly",
4848
"xplat//third-party/glog:glog",
49-
react_native_xplat_target("fabric/debug:debug"),
5049
react_native_xplat_target("fabric/core:core"),
50+
react_native_xplat_target("fabric/debug:debug"),
51+
react_native_xplat_target("fabric/view:view"),
5152
],
5253
)

ReactCommon/fabric/uimanager/FabricUIManager.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#include "FabricUIManager.h"
99

10+
#include <glog/logging.h>
11+
1012
#include <fabric/core/LayoutContext.h>
1113
#include <fabric/view/ViewComponentDescriptor.h>
1214
#include <fabric/view/ViewProps.h>
@@ -97,12 +99,14 @@ void FabricUIManager::completeRoot(int rootTag, const SharedShadowNodeUnsharedLi
9799
LayoutContext layoutContext = LayoutContext();
98100
layoutContext.affectedShadowNodes = std::make_shared<std::unordered_set<SharedLayoutableShadowNode>>();
99101

102+
LOG(INFO) << "Shadow tree *before* layout: \n" << viewShadowNode->getDebugDescription() ;
103+
100104
auto nonConstViewShadowNode = std::const_pointer_cast<ViewShadowNode>(viewShadowNode);
101105
nonConstViewShadowNode->layout(layoutContext);
102106

103107
rootShadowNode->sealRecursive();
104108

105-
printf("## layouted rootShadowNode: %s \n", nonConstViewShadowNode->getDebugDescription(0).c_str());
109+
LOG(INFO) << "Shadow tree *after* layout: \n" << nonConstViewShadowNode->getDebugDescription();
106110
}
107111

108112
} // namespace react

0 commit comments

Comments
 (0)