Skip to content

Commit 539ca06

Browse files
gengjiawenfacebook-github-bot
authored andcommitted
refactor nodejs image in analyze_pr task (facebook#23433)
Summary: move all node image to official one, and remove redundant path. Pull Request resolved: facebook#23433 Differential Revision: D14080808 Pulled By: cpojer fbshipit-source-id: c8f7ec90a8c59129a0d8c5667f3c648dd7865be3
1 parent 410d583 commit 539ca06

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

.circleci/config.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -468,9 +468,8 @@ jobs:
468468
analyze_pr:
469469
<<: *defaults
470470
docker:
471-
- image: circleci/node:10
471+
- image: node:lts
472472
environment:
473-
- PATH: "/opt/yarn/yarn-v1.5.1/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin"
474473
- PUBLIC_PULLBOT_GITHUB_TOKEN_A: "a6edf8e8d40ce4e8b11a"
475474
- PUBLIC_PULLBOT_GITHUB_TOKEN_B: "150e1341f4dd9c944d2a"
476475
- PUBLIC_ANALYSISBOT_GITHUB_TOKEN_A: "78a72af35445ca3f8180"
@@ -487,7 +486,7 @@ jobs:
487486
name: Analyze Shell Scripts
488487
command: |
489488
echo -e "\\x1B[36mInstalling additional dependencies\\x1B[0m"
490-
sudo apt-get install -y shellcheck
489+
apt update && apt install -y shellcheck
491490
yarn add @octokit/rest@15.18.0
492491
echo -e "\\x1B[36mAnalyzing shell scripts\\x1B[0m"; \
493492
GITHUB_TOKEN="$PUBLIC_ANALYSISBOT_GITHUB_TOKEN_A""$PUBLIC_ANALYSISBOT_GITHUB_TOKEN_B" \

0 commit comments

Comments
 (0)