Remove duplicate register call

jacob-israel-turner · facebook-github-bot-7 · commit 5c418655bf34 · 2016-02-24T03:56:31.000-08:00
Summary:Hello! As described in facebook#3288, the `PushNotificationsIOS` `register` callback fires twice. See that issue for discussion. There wasn't any feedback on a proposed PR, so this is the first effort. This change does make the register callback act as expected on my device. I can make any changes necessary. Thanks! Closes facebook#6111 Differential Revision: D2970806 Pulled By: nicklockwood fb-gh-sync-id: a8d0b53210f85cc24b4befdb0e90af46512fa4fb shipit-source-id: a8d0b53210f85cc24b4befdb0e90af46512fa4fb
diff --git a/Libraries/PushNotificationIOS/RCTPushNotificationManager.m b/Libraries/PushNotificationIOS/RCTPushNotificationManager.m
@@ -182,7 +182,6 @@ - (void)handleRemoteNotificationsRegistered:(NSNotification *)notification
     UIUserNotificationSettings *notificationSettings =
       [UIUserNotificationSettings settingsForTypes:(NSUInteger)types categories:nil];
     [app registerUserNotificationSettings:notificationSettings];
-    [app registerForRemoteNotifications];
   } else {
     [app registerForRemoteNotificationTypes:(NSUInteger)types];
   }

Original file line number	Diff line number	Diff line change
`@@ -182,7 +182,6 @@ - (void)handleRemoteNotificationsRegistered:(NSNotification *)notification`
`182`	`182`	`UIUserNotificationSettings *notificationSettings =`
`183`	`183`	`[UIUserNotificationSettings settingsForTypes:(NSUInteger)types categories:nil];`
`184`	`184`	`[app registerUserNotificationSettings:notificationSettings];`
`185`		`- [app registerForRemoteNotifications];`
`186`	`185`	`} else {`
`187`	`186`	`[app registerForRemoteNotificationTypes:(NSUInteger)types];`
`188`	`187`	`}`