Skip to content

Commit 69b17ff

Browse files
alvinthenfacebook-github-bot
authored andcommitted
Update SignedAPKAndroid.md
Summary: Update docs to prevent build process from failing when collaborators do not have MYAPP_RELEASE_STORE_FILE in their env. Build process often fails when following the existing documentation on setting the signingConfigs in build.gradle, as not all collaborators have the required ENV set in their gradle.properties Closes facebook#11716 Differential Revision: D4389150 Pulled By: hramos fbshipit-source-id: 37941382950fac41f19d19317f49769588b135b4
1 parent 036482f commit 69b17ff

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

docs/SignedAPKAndroid.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,12 @@ android {
5454
defaultConfig { ... }
5555
signingConfigs {
5656
release {
57-
storeFile file(MYAPP_RELEASE_STORE_FILE)
58-
storePassword MYAPP_RELEASE_STORE_PASSWORD
59-
keyAlias MYAPP_RELEASE_KEY_ALIAS
60-
keyPassword MYAPP_RELEASE_KEY_PASSWORD
57+
if (project.hasProperty('MYAPP_RELEASE_STORE_FILE')) {
58+
storeFile file(MYAPP_RELEASE_STORE_FILE)
59+
storePassword MYAPP_RELEASE_STORE_PASSWORD
60+
keyAlias MYAPP_RELEASE_KEY_ALIAS
61+
keyPassword MYAPP_RELEASE_KEY_PASSWORD
62+
}
6163
}
6264
}
6365
buildTypes {

0 commit comments

Comments
 (0)