iOS Logbox: always return a turbomodule instance

fkgozali · facebook-github-bot · commit 6ceef13a9cca · 2019-12-16T15:04:27.000-08:00
Summary:
We have assertion to ensure that `getTurboModuleWithJsInvoker:` returns non-nullptr, so conditionally returning `nullptr` is not going to work.

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D19103125

fbshipit-source-id: 663850c01e4db40cca96d254950ea5a7bf6b96b7
diff --git a/React/CoreModules/RCTLogBox.mm b/React/CoreModules/RCTLogBox.mm
@@ -117,11 +117,7 @@ + (BOOL)requiresMainQueueSetup
 
 - (std::shared_ptr<facebook::react::TurboModule>)getTurboModuleWithJsInvoker:(std::shared_ptr<facebook::react::CallInvoker>)jsInvoker
 {
-  if (RCTRedBoxGetEnabled()) {
-    return std::make_shared<facebook::react::NativeLogBoxSpecJSI>(self, jsInvoker);
-  }
-
-  return nullptr;
+  return std::make_shared<facebook::react::NativeLogBoxSpecJSI>(self, jsInvoker);
 }
 
 @end

Original file line number	Diff line number	Diff line change
`@@ -117,11 +117,7 @@ + (BOOL)requiresMainQueueSetup`
`117`	`117`
`118`	`118`	`- (std::shared_ptr<facebook::react::TurboModule>)getTurboModuleWithJsInvoker:(std::shared_ptr<facebook::react::CallInvoker>)jsInvoker`
`119`	`119`	`{`
`120`		`- if (RCTRedBoxGetEnabled()) {`
`121`		`- return std::make_shared<facebook::react::NativeLogBoxSpecJSI>(self, jsInvoker);`
`122`		`- }`
`123`		`-`
`124`		`- return nullptr;`
	`120`	`+ return std::make_shared<facebook::react::NativeLogBoxSpecJSI>(self, jsInvoker);`
`125`	`121`	`}`
`126`	`122`
`127`	`123`	`@end`