Added AnimatedValueXY.removeAllListeners

scarlac · facebook-github-bot · commit 6d2ae35bca7c · 2017-01-14T14:43:27.000-08:00
Summary: > Explain the **motivation** for making this change. What existing problem does the pull request solve? `AnimatedValueX` has `removeAllListeners()` which is a convenient way to do cleanup when components unmount, but `AnimatedValueXY` was missing a similar method which doesn't really make sense. This change makes the two classes more similar, less confusing and more convenient. Closes facebook#11783 Differential Revision: D4397188 fbshipit-source-id: d10a0c9c7e0a83af015ec04f6facf965d95ea984
diff --git a/Libraries/Animated/src/AnimatedImplementation.js b/Libraries/Animated/src/AnimatedImplementation.js
@@ -1030,6 +1030,12 @@ class AnimatedValueXY extends AnimatedWithChildren {
     delete this._listeners[id];
   }
 
+  removeAllListeners(): void {
+    this.x.removeAllListeners();
+    this.y.removeAllListeners();
+    this._listeners = {};
+  }
+
   /**
    * Converts `{x, y}` into `{left, top}` for use in style, e.g.
    *

Original file line number	Diff line number	Diff line change
`@@ -1030,6 +1030,12 @@ class AnimatedValueXY extends AnimatedWithChildren {`
`1030`	`1030`	`delete this._listeners[id];`
`1031`	`1031`	`}`
`1032`	`1032`
	`1033`	`+ removeAllListeners(): void {`
	`1034`	`+ this.x.removeAllListeners();`
	`1035`	`+ this.y.removeAllListeners();`
	`1036`	`+ this._listeners = {};`
	`1037`	`+ }`
	`1038`	`+`
`1033`	`1039`	`/**`
`1034`	`1040`	* Converts `{x, y}` into `{left, top}` for use in style, e.g.
`1035`	`1041`	`*`