Skip to content

Commit 737e011

Browse files
alexeylangfacebook-github-bot-4
authored andcommitted
log native modules init time and config inject time separately
Reviewed By: @tadeuzagallo, @jspahrsummers Differential Revision: D2502620
1 parent c15fd8f commit 737e011

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

React/Base/RCTBatchedBridge.m

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,9 @@ - (void)start
156156
// We're not waiting for this complete to leave the dispatch group, since
157157
// injectJSONConfiguration and executeSourceCode will schedule operations on the
158158
// same queue anyway.
159+
RCTPerformanceLoggerStart(RCTPLNativeModuleInjectConfig);
159160
[weakSelf injectJSONConfiguration:config onComplete:^(NSError *error) {
160-
RCTPerformanceLoggerEnd(RCTPLNativeModuleInit);
161+
RCTPerformanceLoggerEnd(RCTPLNativeModuleInjectConfig);
161162
if (error) {
162163
dispatch_async(dispatch_get_main_queue(), ^{
163164
[weakSelf stopLoadingWithError:error];
@@ -295,6 +296,7 @@ - (void)initModules
295296

296297
[[NSNotificationCenter defaultCenter] postNotificationName:RCTDidCreateNativeModules
297298
object:self];
299+
RCTPerformanceLoggerEnd(RCTPLNativeModuleInit);
298300
}
299301

300302
- (void)setupExecutor

React/Base/RCTPerformanceLogger.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ typedef NS_ENUM(NSUInteger, RCTPLTag) {
1515
RCTPLScriptDownload = 0,
1616
RCTPLScriptExecution,
1717
RCTPLNativeModuleInit,
18+
RCTPLNativeModuleInjectConfig,
1819
RCTPLTTI,
1920
RCTPLSize
2021
};

React/Base/RCTPerformanceLogger.m

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ void RCTPerformanceLoggerEnd(RCTPLTag tag)
3333
@(RCTPLData[RCTPLScriptExecution][1]),
3434
@(RCTPLData[RCTPLNativeModuleInit][0]),
3535
@(RCTPLData[RCTPLNativeModuleInit][1]),
36+
@(RCTPLData[RCTPLNativeModuleInjectConfig][0]),
37+
@(RCTPLData[RCTPLNativeModuleInjectConfig][1]),
3638
@(RCTPLData[RCTPLTTI][0]),
3739
@(RCTPLData[RCTPLTTI][1]),
3840
];
@@ -74,6 +76,7 @@ - (void)sendTimespans
7476
@"ScriptDownload",
7577
@"ScriptExecution",
7678
@"NativeModuleInit",
79+
@"NativeModuleInjectConfig",
7780
@"TTI",
7881
],
7982
]];

0 commit comments

Comments
 (0)