Fix image source prop change updating image

Alexander Jarvis · Facebook Github Bot 5 · commit 7cdd4c9a754e · 2016-08-11T03:28:40.000-07:00
Summary: fixes facebook#7795 fixes facebook#8500 Motivation: When having a simple button that changes the Image source when tapped, the image doesn't change (or at least sometimes, intermittently it works). This was found to be an issue where the request was being sent to the native layer correctly but then being subsequently cancelled by the `reactSetFrame: method` ... Closes facebook#9137 Differential Revision: D3702867 Pulled By: javache fbshipit-source-id: c89ce6b841179394b6b23850b3128751ef9e0313
diff --git a/Libraries/Image/RCTImageView.m b/Libraries/Image/RCTImageView.m
@@ -358,10 +358,6 @@ - (void)reactSetFrame:(CGRect)frame
         _targetSize = idealSize;
         [self reloadImage];
       }
-    } else {
-      // Our existing image is good enough.
-      [self cancelImageLoad];
-      _targetSize = imageSize;
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -358,10 +358,6 @@ - (void)reactSetFrame:(CGRect)frame`
`358`	`358`	`_targetSize = idealSize;`
`359`	`359`	`[self reloadImage];`
`360`	`360`	`}`
`361`		`- } else {`
`362`		`- // Our existing image is good enough.`
`363`		`- [self cancelImageLoad];`
`364`		`- _targetSize = imageSize;`
`365`	`361`	`}`
`366`	`362`	`}`
`367`	`363`	`}`