Loosen Platform check to allow better code sharing for out-of-tree platforms

Matt Hargett · facebook-github-bot · commit 84affbd6a371 · 2018-03-12T08:43:05.000-07:00
Summary: Don't lock out other non-iOS platforms (e.g. Windows) with an overly specific check. This change allows this JS file to be re-used instead of copied and modified. There was one other instance of this pattern, but I'll submit it separate for easier cherry-picking. Tested Android and iOS playground on simulators. [GENERAL] [ENHANCEMENT] - some core ReactNative JS library files will be easier to re-use across RN platforms. Closes facebook#18308 Differential Revision: D7230803 Pulled By: hramos fbshipit-source-id: 11e03183535a7453cee00dc1e795c27f2fd2bf5d
diff --git a/Libraries/ReactNative/UIManager.js b/Libraries/ReactNative/UIManager.js
@@ -77,7 +77,7 @@ if (Platform.OS === 'ios') {
       });
     }
   });
-} else if (Platform.OS === 'android' && UIManager.ViewManagerNames) {
+} else if (UIManager.ViewManagerNames) {
   UIManager.ViewManagerNames.forEach(viewManagerName => {
     defineLazyObjectProperty(UIManager, viewManagerName, {
       get: () => UIManager.getConstantsForViewManager(viewManagerName),

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ if (Platform.OS === 'ios') {`
`77`	`77`	`});`
`78`	`78`	`}`
`79`	`79`	`});`
`80`		`-} else if (Platform.OS === 'android' && UIManager.ViewManagerNames) {`
	`80`	`+} else if (UIManager.ViewManagerNames) {`
`81`	`81`	`UIManager.ViewManagerNames.forEach(viewManagerName => {`
`82`	`82`	`defineLazyObjectProperty(UIManager, viewManagerName, {`
`83`	`83`	`get: () => UIManager.getConstantsForViewManager(viewManagerName),`