Fabric: New UIManager registration process (beginning)

Summary:
This diff introduces a new integration concept (called RuntimeExecutor) which consolidates `Runtime` and the dispatching mechanism.
As simple as that:
`using RuntimeExecutor = std::function<void(std::function<void(facebook::jsi::Runtime &runtime)> &&callback)>;`

Reviewed By: fkgozali

Differential Revision: D12816746

fbshipit-source-id: 9e27ef16b98af861d494fe50c7e50bd0536e6aaf

Author: shergin

React/Base/RCTBridge+Private.h

@@ -144,6 +144,8 @@ RCT_EXTERN void RCTRegisterModule(Class);
 
 @interface RCTCxxBridge : RCTBridge
 
+@property (nonatomic) void *runtime;
+
 - (instancetype)initWithParentBridge:(RCTBridge *)bridge NS_DESIGNATED_INITIALIZER;
 
 @end

React/CxxBridge/RCTCxxBridge.mm

@@ -57,6 +57,7 @@
 typedef void (^RCTPendingCall)();
 
 using namespace facebook::jsc;
+using namespace facebook::jsi;
 using namespace facebook::react;
 
 /**
@@ -1229,4 +1230,13 @@ - (BOOL)isBatchActive
   return _wasBatchActive;
 }
 
+- (void *)runtime
+{
+  if (!_reactInstance) {
+    return nullptr;
+  }
+
+  return _reactInstance->getJavaScriptContext();
+}
+
 @end

React/Fabric/RCTSurfacePresenter.h

@@ -79,9 +79,9 @@ NS_ASSUME_NONNULL_BEGIN
 
 @end
 
-@interface RCTBridge (RCTSurfacePresenter)
+@interface RCTBridge (Deprecated)
 
-- (RCTSurfacePresenter *)surfacePresenter;
+@property (nonatomic) RCTSurfacePresenter *surfacePresenter;
 
 @end
 

React/Fabric/RCTSurfacePresenter.mm

@@ -7,7 +7,10 @@
 
 #import "RCTSurfacePresenter.h"
 
+#import <objc/runtime.h>
 #import <mutex>
+#import <jsi/jsi.h>
+#import <cxxreact/MessageQueueThread.h>
 
 #import <React/RCTAssert.h>
 #import <React/RCTBridge+Private.h>
@@ -153,6 +156,14 @@ - (RCTScheduler *)_scheduler
   auto contextContainer = std::make_shared<ContextContainer>();
 
   auto messageQueueThread = _batchedBridge.jsMessageThread;
+  auto runtime = (facebook::jsi::Runtime *)((RCTCxxBridge *)_batchedBridge).runtime;
+
+  RuntimeExecutor runtimeExecutor =
+    [runtime, messageQueueThread](std::function<void(facebook::jsi::Runtime &runtime)> &&callback) {
+      messageQueueThread->runOnQueue([runtime, callback = std::move(callback)]() {
+        callback(*runtime);
+      });
+    };
 
   EventBeatFactory synchronousBeatFactory = [messageQueueThread]() {
     return std::make_unique<MainRunLoopEventBeat>(messageQueueThread);
@@ -165,8 +176,7 @@ - (RCTScheduler *)_scheduler
   contextContainer->registerInstance<EventBeatFactory>(synchronousBeatFactory, "synchronous");
   contextContainer->registerInstance<EventBeatFactory>(asynchronousBeatFactory, "asynchronous");
 
-  contextContainer->registerInstance(_uiManagerInstaller, "uimanager-installer");
-  contextContainer->registerInstance(_uiManagerUninstaller, "uimanager-uninstaller");
+  contextContainer->registerInstance(runtimeExecutor, "runtime-executor");
 
   contextContainer->registerInstance(std::make_shared<ImageManager>((__bridge void *)[_bridge imageLoader]));
 
@@ -307,3 +317,17 @@ - (RCTBridge *)bridge_DO_NOT_USE
 }
 
 @end
+
+@implementation RCTBridge (Deprecated)
+
+- (void)setSurfacePresenter:(RCTSurfacePresenter *)surfacePresenter
+{
+  objc_setAssociatedObject(self, @selector(surfacePresenter), surfacePresenter, OBJC_ASSOCIATION_RETAIN_NONATOMIC);
+}
+
+- (RCTSurfacePresenter *)surfacePresenter
+{
+  return objc_getAssociatedObject(self, @selector(surfacePresenter));
+}
+
+@end

ReactCommon/fabric/uimanager/BUCK

@@ -55,7 +55,10 @@ rn_xplat_cxx_library(
         "xplat//folly:headers_only",
         "xplat//folly:memory",
         "xplat//folly:molly",
+        "xplat//jsi:JSIDynamic",
+        "xplat//jsi:jsi",
         "xplat//third-party/glog:glog",
+        react_native_xplat_target("cxxreact:bridge"),
         react_native_xplat_target("fabric/components/root:root"),
         react_native_xplat_target("fabric/components/view:view"),
         react_native_xplat_target("fabric/core:core"),

ReactCommon/fabric/uimanager/FabricUIManager.h

@@ -10,6 +10,7 @@
 #include <memory>
 
 #include <folly/dynamic.h>
+#include <jsi/jsi.h>
 
 #include <fabric/core/ShadowNode.h>
 #include <fabric/events/EventBeatBasedExecutor.h>
@@ -22,6 +23,9 @@ namespace react {
 class FabricUIManager;
 using UIManager = FabricUIManager;
 
+using RuntimeExecutor = std::function<void(
+    std::function<void(facebook::jsi::Runtime &runtime)> &&callback)>;
+
 /*
  * Particular implementations of those functions should capture references to
  * the runtime and ensure proper threading.