Skip to content

Commit 9b261db

Browse files
andreicoman11Facebook Github Bot
authored andcommitted
Modal statusbar cleanup
Summary: The hack for the status bar height is not necessary any longer, so we can remove all code related to it Reviewed By: lexs Differential Revision: D3943770 fbshipit-source-id: 2d70f4ea10dd76ea6e6a73bb6edccae388bde1c0
1 parent 12a97e1 commit 9b261db

File tree

2 files changed

+1
-22
lines changed

2 files changed

+1
-22
lines changed

ReactAndroid/src/main/java/com/facebook/react/shell/MainReactPackage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ public List<ViewManager> createViewManagers(ReactApplicationContext reactContext
233233
new ReactDropdownPickerManager(),
234234
new ReactHorizontalScrollViewManager(),
235235
new ReactImageManager(),
236-
new ReactModalHostManager(reactContext),
236+
new ReactModalHostManager(),
237237
new ReactProgressBarViewManager(),
238238
new ReactRawTextManager(),
239239
new ReactScrollViewManager(),

ReactAndroid/src/main/java/com/facebook/react/views/modal/ReactModalHostManager.java

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,12 @@
99

1010
package com.facebook.react.views.modal;
1111

12-
import javax.annotation.Nullable;
13-
1412
import java.util.Map;
1513

1614
import android.content.DialogInterface;
1715

18-
import com.facebook.react.bridge.ReactApplicationContext;
1916
import com.facebook.react.common.MapBuilder;
2017
import com.facebook.react.uimanager.LayoutShadowNode;
21-
import com.facebook.react.uimanager.PixelUtil;
2218
import com.facebook.react.uimanager.ThemedReactContext;
2319
import com.facebook.react.uimanager.UIManagerModule;
2420
import com.facebook.react.uimanager.ViewGroupManager;
@@ -32,12 +28,6 @@ public class ReactModalHostManager extends ViewGroupManager<ReactModalHostView>
3228

3329
private static final String REACT_CLASS = "RCTModalHostView";
3430

35-
private final ReactApplicationContext mContext;
36-
37-
public ReactModalHostManager(ReactApplicationContext context) {
38-
mContext = context;
39-
}
40-
4131
@Override
4232
public String getName() {
4333
return REACT_CLASS;
@@ -104,17 +94,6 @@ public Map<String, Object> getExportedCustomDirectEventTypeConstants() {
10494
.build();
10595
}
10696

107-
@Override
108-
public @Nullable Map<String, Object> getExportedViewConstants() {
109-
final int heightResId = mContext.getResources().getIdentifier("status_bar_height", "dimen", "android");
110-
final float height = heightResId > 0 ?
111-
PixelUtil.toDIPFromPixel(mContext.getResources().getDimensionPixelSize(heightResId)) :
112-
0;
113-
114-
return MapBuilder.<String, Object>of(
115-
"StatusBarHeight", height);
116-
}
117-
11897
@Override
11998
protected void onAfterUpdateTransaction(ReactModalHostView view) {
12099
super.onAfterUpdateTransaction(view);

0 commit comments

Comments
 (0)