Skip to content

Commit 9cefc96

Browse files
sammy-SCfacebook-github-bot
authored andcommitted
Remove redundant props from Picker
Summary: Props are being ignored on native side, let's get rid of them. Reviewed By: TheSavior Differential Revision: D17765185 fbshipit-source-id: d3625dd25d2e41a49e701d54fe9a7b74cd47786c
1 parent f580409 commit 9cefc96

File tree

3 files changed

+0
-10
lines changed

3 files changed

+0
-10
lines changed

Libraries/Components/Picker/PickerIOS.ios.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ type RCTPickerIOSType = Class<
4444
$ReadOnly<{|
4545
items: $ReadOnlyArray<RCTPickerIOSItemType>,
4646
onChange: (event: PickerIOSChangeEvent) => void,
47-
onResponderTerminationRequest: () => boolean,
48-
onStartShouldSetResponder: () => boolean,
4947
selectedIndex: number,
5048
style?: ?TextStyleProp,
5149
testID?: ?string,
@@ -119,8 +117,6 @@ class PickerIOS extends React.Component<Props, State> {
119117
items={this.state.items}
120118
selectedIndex={this.state.selectedIndex}
121119
onChange={this._onChange}
122-
onStartShouldSetResponder={() => true}
123-
onResponderTerminationRequest={() => false}
124120
/>
125121
</View>
126122
);

Libraries/Components/Picker/RCTPickerNativeComponent.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@ type RCTPickerIOSType = Class<
3535
$ReadOnly<{|
3636
items: $ReadOnlyArray<RCTPickerIOSItemType>,
3737
onChange: (event: PickerIOSChangeEvent) => void,
38-
onResponderTerminationRequest: () => boolean,
39-
onStartShouldSetResponder: () => boolean,
4038
selectedIndex: number,
4139
style?: ?TextStyleProp,
4240
testID?: ?string,

Libraries/Components/Picker/__tests__/__snapshots__/Picker-test.js.snap

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ exports[`<Picker /> should render as <View> when mocked 1`] = `
1818
]
1919
}
2020
onChange={[Function]}
21-
onResponderTerminationRequest={[Function]}
22-
onStartShouldSetResponder={[Function]}
2321
selectedIndex={0}
2422
style={
2523
Array [
@@ -51,8 +49,6 @@ exports[`<Picker /> should render as <View> when not mocked 1`] = `
5149
]
5250
}
5351
onChange={[Function]}
54-
onResponderTerminationRequest={[Function]}
55-
onStartShouldSetResponder={[Function]}
5652
selectedIndex={0}
5753
style={
5854
Array [

0 commit comments

Comments
 (0)