Inspector crashes when a device name contained spaces

pakoito · facebook-github-bot · commit 9df79e7e9632 · 2017-07-18T10:52:23.000-07:00
Reviewed By: Hypuk

Differential Revision: D5434498

fbshipit-source-id: f758497ca50e4c02e436812725acfe0dcb8428b4
diff --git a/React/DevSupport/RCTInspectorDevServerHelper.mm b/React/DevSupport/RCTInspectorDevServerHelper.mm
@@ -30,9 +30,10 @@
 
 static NSURL *getInspectorDeviceUrl(NSURL *bundleURL)
 {
+  NSString *escapedText = [[[UIDevice currentDevice] name] stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
   return [NSURL URLWithString:[NSString stringWithFormat:@"http://%@/inspector/device?name=%@",
                                                         getDebugServerHost(bundleURL),
-                                                        [[UIDevice currentDevice] name]]];
+                                                        escapedText]];
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -30,9 +30,10 @@`
`30`	`30`
`31`	`31`	`static NSURL getInspectorDeviceUrl(NSURL bundleURL)`
`32`	`32`	`{`
	`33`	`+ NSString *escapedText = [[[UIDevice currentDevice] name] stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];`
`33`	`34`	`return [NSURL URLWithString:[NSString stringWithFormat:@"http://%@/inspector/device?name=%@",`
`34`	`35`	`getDebugServerHost(bundleURL),`
`35`		`- [[UIDevice currentDevice] name]]];`
	`36`	`+ escapedText]];`
`36`	`37`	`}`
`37`	`38`
`38`	`39`