Skip to content

Commit a2a8d7f

Browse files
donyuFacebook Github Bot 2
authored andcommitted
Fix onItemSelected firing for ReactPicker on initial layout.
Reviewed By: AaaChiuuu Differential Revision: D3732557 fbshipit-source-id: ed031dbf205996dab8cb0555af972e6f26c0d202
1 parent 50e0d8e commit a2a8d7f

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

ReactAndroid/src/main/java/com/facebook/react/views/picker/ReactPicker.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,10 @@ public void requestLayout() {
7979

8080
public void setOnSelectListener(@Nullable OnSelectListener onSelectListener) {
8181
if (getOnItemSelectedListener() == null) {
82+
// onItemSelected gets fired immediately after layout because checkSelectionChanged() in
83+
// AdapterView updates the selection position from the default INVALID_POSITION. To match iOS
84+
// behavior, we don't want the event emitter for onItemSelected to fire right after layout.
85+
mSuppressNextEvent = true;
8286
setOnItemSelectedListener(
8387
new OnItemSelectedListener() {
8488
@Override

0 commit comments

Comments
 (0)