Skip to content

Commit b59fde8

Browse files
bestanderFacebook Github Bot 6
authored andcommitted
Fixes paths to robolectric when they are downloaded from maven into buck-out
Reviewed By: mmmulani Differential Revision: D3751888 fbshipit-source-id: 2a70e8655f3c6e6dcc2de17e85289d9db18a2699
1 parent 84f68c3 commit b59fde8

File tree

1 file changed

+30
-4
lines changed
  • ReactAndroid/src/main/third-party/java/robolectric3/robolectric

1 file changed

+30
-4
lines changed

ReactAndroid/src/main/third-party/java/robolectric3/robolectric/BUCK

Lines changed: 30 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,16 @@ prebuilt_jar(
110110
visibility = ['//ReactAndroid/...',],
111111
)
112112

113-
remote_file(
113+
# This new rule will make the .jar file appear in the "right" location,
114+
# though that may change in the future
115+
export_file(
114116
name = 'robolectric-android-all-binary-jar',
117+
src = ':robolectric-android-all-binary-remote-jar',
118+
out = 'android-all-4.1.2_r1-robolectric-0.jar', # name defines filename used by robolectric in runtime
119+
)
120+
121+
remote_file(
122+
name = 'robolectric-android-all-binary-remote-jar',
115123
url = 'mvn:org.robolectric:android-all:jar:4.1.2_r1-robolectric-0',
116124
sha1 = 'aecc8ce5119a25fcea1cdf8285469c9d1261a352',
117125
)
@@ -122,8 +130,14 @@ prebuilt_jar(
122130
visibility = ['//ReactAndroid/...',],
123131
)
124132

125-
remote_file(
133+
export_file(
126134
name = 'json-jar',
135+
src = ':json-remote-jar',
136+
out = 'json-20080701.jar', # name defines filename used by robolectric in runtime
137+
)
138+
139+
remote_file(
140+
name = 'json-remote-jar',
127141
url = 'mvn:org.json:json:jar:20080701',
128142
sha1 = 'd652f102185530c93b66158b1859f35d45687258',
129143
)
@@ -134,8 +148,14 @@ prebuilt_jar(
134148
visibility = ['//ReactAndroid/...',],
135149
)
136150

137-
remote_file(
151+
export_file(
138152
name = 'tagsoup-jar',
153+
src = ':tagsoup-remote-jar',
154+
out = 'tagsoup-1.2.jar', # name defines filename used by robolectric in runtime
155+
)
156+
157+
remote_file(
158+
name = 'tagsoup-remote-jar',
139159
url = 'mvn:org.ccil.cowan.tagsoup:tagsoup:jar:1.2',
140160
sha1 = '639fd364750d7363c85797dc944b4a80f78fa684',
141161
)
@@ -146,8 +166,14 @@ prebuilt_jar(
146166
visibility = ['//ReactAndroid/...',],
147167
)
148168

149-
remote_file(
169+
export_file(
150170
name = 'robolectric-shadows-binary-jar',
171+
src = ':robolectric-shadows-binary-remote-jar',
172+
out = 'shadows-core-3.0-16.jar', # name defines filename used by robolectric in runtime
173+
)
174+
175+
remote_file(
176+
name = 'robolectric-shadows-binary-remote-jar',
151177
url = 'https://repo1.maven.org/maven2/org/robolectric/shadows-core/3.0/shadows-core-3.0-16.jar',
152178
sha1 = '39d7a856bf91640b1a6d044333336a2b3f3c198f',
153179
)

0 commit comments

Comments
 (0)