Fabric: Removed unnecessary call in RootShadowNode::clone

shergin · facebook-github-bot · commit b93221036a3e · 2019-03-18T23:56:13.000-07:00
Summary: The removed code does nothing because we are replacing the oldChild with newChild several lines above.

Reviewed By: JoshuaGross

Differential Revision: D14402637

fbshipit-source-id: 731a950f373e20f7d5bae3cbf6470335d3694ccc
diff --git a/ReactCommon/fabric/components/root/RootShadowNode.cpp b/ReactCommon/fabric/components/root/RootShadowNode.cpp
@@ -70,8 +70,6 @@ UnsharedRootShadowNode RootShadowNode::clone(
         /* .children = */ sharedChildren,
     });
 
-    newParent->replaceChild(oldChild, newChild);
-
     oldChild = oldParent;
     newChild = newParent;
   }

Original file line number	Diff line number	Diff line change
`@@ -70,8 +70,6 @@ UnsharedRootShadowNode RootShadowNode::clone(`
`70`	`70`	`/* .children = */ sharedChildren,`
`71`	`71`	`});`
`72`	`72`
`73`		`- newParent->replaceChild(oldChild, newChild);`
`74`		`-`
`75`	`73`	`oldChild = oldParent;`
`76`	`74`	`newChild = newParent;`
`77`	`75`	`}`