Fixed reverse logic in ReactToolbarManager setRtl.

danielbraun · Facebook Github Bot 9 · commit c15e2bb61981 · 2016-08-02T12:28:33.000-07:00
Summary: The logic in `setRtl` is wrong. You would expect that `{rtl: true}` would set the layout direction to RTL, instead it currently does the opposite. This commit fixes the issue. Closes facebook#9132 Differential Revision: D3657134 fbshipit-source-id: f946698b548988541de7da5565d2ab122746ecf0
diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/toolbar/ReactToolbarManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/toolbar/ReactToolbarManager.java
@@ -67,7 +67,7 @@ public void setOverflowIcon(ReactToolbar view, @Nullable ReadableMap overflowIco
 
   @ReactProp(name = "rtl")
   public void setRtl(ReactToolbar view, boolean rtl) {
-    view.setLayoutDirection(rtl ? LayoutDirection.LTR : LayoutDirection.RTL);
+    view.setLayoutDirection(rtl ? LayoutDirection.RTL : LayoutDirection.LTR);
   }
 
   @ReactProp(name = "subtitle")

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ public void setOverflowIcon(ReactToolbar view, @Nullable ReadableMap overflowIco`
`67`	`67`
`68`	`68`	`@ReactProp(name = "rtl")`
`69`	`69`	`public void setRtl(ReactToolbar view, boolean rtl) {`
`70`		`- view.setLayoutDirection(rtl ? LayoutDirection.LTR : LayoutDirection.RTL);`
	`70`	`+ view.setLayoutDirection(rtl ? LayoutDirection.RTL : LayoutDirection.LTR);`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`@ReactProp(name = "subtitle")`