Use direct access to YogaConfig mNativePointer parameter

amir-shalem · facebook-github-bot · commit c205b1d39155 · 2019-09-22T13:48:52.000-07:00
Summary:
Use direct access to YogaConfig mNativePointer parameter

Results:
```
The following primary metrics showed statistically significant changes at the 95% confidence level:
javaFullLifecycleAllocateCalculateReadLayout	-1.25%
javaLayoutReading	0.44%
javaYogaNodeAllocateAndSetProps	-1.92%
javaYogaNodeAllocation	-2.11%
javaYogaNodeStylePropAssignment	-0.89%
```

Differential Revision: D17519542

fbshipit-source-id: c39bfe1b0ecae9149dc6da2a0a7e936df215ec5b
diff --git a/ReactAndroid/src/main/java/com/facebook/yoga/YogaConfigJNIBase.java b/ReactAndroid/src/main/java/com/facebook/yoga/YogaConfigJNIBase.java
@@ -8,7 +8,7 @@
 
 public abstract class YogaConfigJNIBase extends YogaConfig {
 
-  protected long mNativePointer;
+  long mNativePointer;
   private YogaLogger mLogger;
 
   private YogaConfigJNIBase(long nativePointer) {
diff --git a/ReactAndroid/src/main/java/com/facebook/yoga/YogaNodeJNIBase.java b/ReactAndroid/src/main/java/com/facebook/yoga/YogaNodeJNIBase.java
@@ -58,7 +58,7 @@ private YogaNodeJNIBase(long nativePointer) {
   }
 
   YogaNodeJNIBase(YogaConfig config) {
-    this(YogaNative.jni_YGNodeNewWithConfig(config.getNativePointer()));
+    this(YogaNative.jni_YGNodeNewWithConfig(((YogaConfigJNIBase)config).mNativePointer));
   }
 
   public void reset() {

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ private YogaNodeJNIBase(long nativePointer) {`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`YogaNodeJNIBase(YogaConfig config) {`
`61`		`- this(YogaNative.jni_YGNodeNewWithConfig(config.getNativePointer()));`
	`61`	`+ this(YogaNative.jni_YGNodeNewWithConfig(((YogaConfigJNIBase)config).mNativePointer));`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`public void reset() {`