Commit c3e6165
Warn if base !== master, tag CODEOWNERS
Summary:
The following PR modifies the Danger rules in the following way:
1. Verifies if a PR is opened against master. If not, it will warn (if opened against stable) or fail (anything else).
2. No longer adds a markdown message tagging the facebook/react-native team, as the bot does not have the necessary scope to mention the team.
3. Mentions people that have marked themselves as interested in a file, when that file is modified. This is based off CODEOWNERS. The bot should be able to use mentions here as it will act as any other regular user.
Verify it tags the right people in facebook#15139
```
$ npm run danger pr facebook#15139
> @ danger /Users/hramos/git/react-native/danger
> node ./node_modules/.bin/danger "pr" "facebook#15139"
{
fails: [],
warnings: [],
messages: [],
markdowns: ["Attention: grabbou, kureev"]
}
```
It should not tag anyone for facebook#15175:
```
$ npm run danger pr facebook#15175
> @ danger /Users/hramos/git/react-native/danger
> node ./node_modules/.bin/danger "pr" "facebook#15175"
{
fails: [],
warnings: [],
messages: [],
markdowns: []
}
```
It should warn on facebook#14640 as it targets 0.45-stable:
```
$ npm run danger pr facebook#14640
> @ danger /Users/hramos/git/react-native/danger
> node ./node_modules/.bin/danger "pr" "facebook#14640"
{
fails: [],
warnings: [
{
message: ":grey_question: Base Branch - <i>The base branch for this PR is something other than `master`. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on `master` first and then cherry-pick the commits into the branch for that release. The [Releases Guide](https://github.com/facebook/react-native/blob/master/Releases.md) has more information.</i>"
}
],
messages: [],
markdowns: [":page_facing_up: Thanks for your contribution to the docs!"]
}
```
It should not warn on facebook#15175 because it targets master.
```
$ npm run danger pr facebook#15175
> @ danger /Users/hramos/git/react-native/danger
> node ./node_modules/.bin/danger "pr" "facebook#15175"
{
fails: [],
warnings: [],
messages: [],
markdowns: []
}
```
Closes facebook#15179
Differential Revision: D5490047
Pulled By: hramos
fbshipit-source-id: a46a23b7d0a59d12b8039746d6e9c4399ef32d5f1 parent fbaedfd commit c3e6165
2 files changed
+37
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
36 | | - | |
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
47 | 46 | | |
48 | 47 | | |
49 | 48 | | |
| |||
66 | 65 | | |
67 | 66 | | |
68 | 67 | | |
69 | | - | |
70 | 68 | | |
71 | 69 | | |
72 | 70 | | |
| |||
102 | 100 | | |
103 | 101 | | |
104 | 102 | | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
0 commit comments