Remove unwanted animations

sammy-SC · facebook-github-bot · commit c774cb8ec50f · 2020-03-16T02:43:29.000-07:00
Summary:
Changelog: [internal]

# Problem
Assigning `CALayer.contents` implicitly animates the difference. As we keep `UIView` in recycle pool between usages, they keep their previous state. This was causing animation of border when the views were being reused.

# Solution
Wrapping application of mutations in `CATTransaction`.

Reviewed By: shergin

Differential Revision: D20442045

fbshipit-source-id: 214d6c422f23f399dec46b5bf1a38a7b64758160
diff --git a/React/Fabric/Mounting/RCTMountingManager.mm b/React/Fabric/Mounting/RCTMountingManager.mm
@@ -135,6 +135,8 @@ static void RNPerformMountInstructions(
 {
   SystraceSection s("RNPerformMountInstructions");
 
+  [CATransaction begin];
+  [CATransaction setValue:(id)kCFBooleanTrue forKey:kCATransactionDisableActions];
   for (auto const &mutation : mutations) {
     switch (mutation.type) {
       case ShadowViewMutation::Create: {
@@ -189,6 +191,7 @@ static void RNPerformMountInstructions(
       }
     }
   }
+  [CATransaction commit];
 }
 
 @implementation RCTMountingManager {

Original file line number	Diff line number	Diff line change
`@@ -135,6 +135,8 @@ static void RNPerformMountInstructions(`
`135`	`135`	`{`
`136`	`136`	`SystraceSection s("RNPerformMountInstructions");`
`137`	`137`
	`138`	`+ [CATransaction begin];`
	`139`	`+ [CATransaction setValue:(id)kCFBooleanTrue forKey:kCATransactionDisableActions];`
`138`	`140`	`for (auto const &mutation : mutations) {`
`139`	`141`	`switch (mutation.type) {`
`140`	`142`	`case ShadowViewMutation::Create: {`
`@@ -189,6 +191,7 @@ static void RNPerformMountInstructions(`
`189`	`191`	`}`
`190`	`192`	`}`
`191`	`193`	`}`
	`194`	`+ [CATransaction commit];`
`192`	`195`	`}`
`193`	`196`
`194`	`197`	`@implementation RCTMountingManager {`