Use compiler flag -fvisibility=hidden

Summary:
Using compiler flag -fvisibility=hidden and explicitly setting visibility to default to public methods

#Changelog:
[Internal] [Yoga] Use compiler flag -fvisibility=hidden for reducing yoga binary size

Reviewed By: astreet

Differential Revision: D18029030

fbshipit-source-id: 545e73f9c25f3108fc9d9bb7f08c157dbc8da005

Author: SidharthGuglani-zz

ReactAndroid/src/main/jni/first-party/yogajni/jni/corefunctions.cpp

@@ -42,7 +42,8 @@ jint ensureInitialized(JNIEnv** env, JavaVM* vm) {
   return JNI_VERSION_1_6;
 }
 
-JNIEnv* getCurrentEnv() {
+// TODO why we need JNIEXPORT for getCurrentEnv ?
+JNIEXPORT JNIEnv* getCurrentEnv() {
   JNIEnv* env;
   jint ret = globalVm->GetEnv((void**) &env, JNI_VERSION_1_6);
   if (ret != JNI_OK) {

ReactCommon/yoga/yoga/CompactValue.h

@@ -8,7 +8,7 @@
 #pragma once
 
 #include "YGValue.h"
-
+#include "YGMacros.h"
 #include <cmath>
 #include <cstdint>
 #include <limits>
@@ -40,7 +40,7 @@ namespace detail {
 //            0x40000000         0x7f7fffff
 // - Zero is supported, negative zero is not
 // - values outside of the representable range are clamped
-class CompactValue {
+class YOGA_EXPORT CompactValue {
   friend constexpr bool operator==(CompactValue, CompactValue) noexcept;
 
 public:

ReactCommon/yoga/yoga/YGConfig.h

@@ -9,7 +9,7 @@
 #include "Yoga-internal.h"
 #include "Yoga.h"
 
-struct YGConfig {
+struct YOGA_EXPORT YGConfig {
   using LogWithContextFn = int (*)(
       YGConfigRef config,
       YGNodeRef node,

ReactCommon/yoga/yoga/YGMacros.h

@@ -21,6 +21,14 @@
 #define WIN_EXPORT
 #endif
 
+#ifndef YOGA_EXPORT
+#ifdef _MSC_VER
+#define YOGA_EXPORT
+#else
+#define YOGA_EXPORT __attribute__((visibility("default")))
+#endif
+#endif
+
 #ifdef NS_ENUM
 // Cannot use NSInteger as NSInteger has a different size than int (which is the
 // default type of a enum). Therefor when linking the Yoga C library into obj-c

ReactCommon/yoga/yoga/YGNode.cpp

@@ -188,7 +188,7 @@ void YGNode::setMeasureFunc(YGMeasureFunc measureFunc) {
   setMeasureFunc(m);
 }
 
-void YGNode::setMeasureFunc(MeasureWithContextFn measureFunc) {
+YOGA_EXPORT void YGNode::setMeasureFunc(MeasureWithContextFn measureFunc) {
   flags_.at<measureUsesContext_>() = true;
   decltype(YGNode::measure_) m;
   m.withContext = measureFunc;
@@ -378,7 +378,7 @@ YGDirection YGNode::resolveDirection(const YGDirection ownerDirection) {
   }
 }
 
-void YGNode::clearChildren() {
+YOGA_EXPORT void YGNode::clearChildren() {
   children_.clear();
   children_.shrink_to_fit();
 }

ReactCommon/yoga/yoga/YGNode.h

@@ -18,7 +18,7 @@
 
 YGConfigRef YGConfigGetDefault();
 
-struct YGNode {
+struct YOGA_EXPORT YGNode {
   using MeasureWithContextFn =
       YGSize (*)(YGNode*, float, YGMeasureMode, float, YGMeasureMode, void*);
   using BaselineWithContextFn = float (*)(YGNode*, float, float, void*);

ReactCommon/yoga/yoga/YGStyle.h

@@ -17,7 +17,7 @@
 #include "Yoga-internal.h"
 #include "Yoga.h"
 
-class YGStyle {
+class YOGA_EXPORT YGStyle {
   template <typename Enum>
   using Values =
       facebook::yoga::detail::Values<facebook::yoga::enums::count<Enum>()>;
@@ -197,7 +197,7 @@ class YGStyle {
   Ref<YGFloatOptional, &YGStyle::aspectRatio_> aspectRatio() { return {*this}; }
 };
 
-bool operator==(const YGStyle& lhs, const YGStyle& rhs);
-inline bool operator!=(const YGStyle& lhs, const YGStyle& rhs) {
+YOGA_EXPORT bool operator==(const YGStyle& lhs, const YGStyle& rhs);
+YOGA_EXPORT inline bool operator!=(const YGStyle& lhs, const YGStyle& rhs) {
   return !(lhs == rhs);
 }

ReactCommon/yoga/yoga/YGValue.h

@@ -26,9 +26,9 @@ typedef struct YGValue {
   YGUnit unit;
 } YGValue;
 
-extern const YGValue YGValueAuto;
-extern const YGValue YGValueUndefined;
-extern const YGValue YGValueZero;
+YOGA_EXPORT extern const YGValue YGValueAuto;
+YOGA_EXPORT extern const YGValue YGValueUndefined;
+YOGA_EXPORT extern const YGValue YGValueZero;
 
 YG_EXTERN_C_END