Skip to content

Commit edd22bf

Browse files
davidaureliofacebook-github-bot
authored andcommitted
Log bridge description for e2e reloads
Reviewed By: mhorowitz Differential Revision: D7577953 fbshipit-source-id: 96871c664cb7ec84570bc76f2edb36ff8c8c6aeb
1 parent 6924d44 commit edd22bf

File tree

3 files changed

+12
-1
lines changed

3 files changed

+12
-1
lines changed

React/Base/RCTBridge.h

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,12 @@ RCT_EXTERN NSString *const RCTBridgeDidDownloadScriptNotification;
7272
*/
7373
RCT_EXTERN NSString *const RCTBridgeDidDownloadScriptNotificationSourceKey;
7474

75+
/**
76+
* Key for the bridge description (NSString_ in the
77+
* RCTBridgeDidDownloadScriptNotification userInfo dictionary.
78+
*/
79+
RCT_EXTERN NSString *const RCTBridgeDidDownloadScriptNotificationBridgeDescriptionKey;
80+
7581
/**
7682
* This block can be used to instantiate modules that require additional
7783
* init parameters, or additional configuration prior to being used.

React/Base/RCTBridge.m

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
NSString *const RCTBridgeWillDownloadScriptNotification = @"RCTBridgeWillDownloadScriptNotification";
3232
NSString *const RCTBridgeDidDownloadScriptNotification = @"RCTBridgeDidDownloadScriptNotification";
3333
NSString *const RCTBridgeDidDownloadScriptNotificationSourceKey = @"source";
34+
NSString *const RCTBridgeDidDownloadScriptNotificationBridgeDescriptionKey = @"bridgeDescription";
3435

3536
static NSMutableArray<Class> *RCTModuleClasses;
3637
NSArray<Class> *RCTGetModuleClasses(void)

React/CxxBridge/RCTCxxBridge.mm

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,11 @@ - (void)loadSource:(RCTSourceLoadBlock)_onSourceLoad onProgress:(RCTSourceLoadPr
400400
[performanceLogger markStopForTag:RCTPLScriptDownload];
401401
[performanceLogger setValue:source.length forTag:RCTPLBundleSize];
402402

403-
NSDictionary *userInfo = source ? @{ RCTBridgeDidDownloadScriptNotificationSourceKey: source } : nil;
403+
NSDictionary *userInfo = @{
404+
RCTBridgeDidDownloadScriptNotificationSourceKey: source ?: [NSNull null],
405+
RCTBridgeDidDownloadScriptNotificationBridgeDescriptionKey: self->_bridgeDescription ?: [NSNull null],
406+
};
407+
404408
[center postNotificationName:RCTBridgeDidDownloadScriptNotification object:self->_parentBridge userInfo:userInfo];
405409

406410
_onSourceLoad(error, source);

0 commit comments

Comments
 (0)