Skip to content

Commit f088bca

Browse files
ProgressBarAndroid checks indeterminate prop type manually
Summary: Causes a YellowBox warning: "You are manually calling a React.PropTypes validation function for 'indeterminate' prop on 'ProgressBarAndroid'." Initially reported here: facebook#9692 but closed by the creator because he switched to using ActivityIndicator. Fixed as per the guidelines here: https://facebook.github.io/react/warnings/dont-call-proptypes.html ``` /** * Sample React Native App * https://github.com/facebook/react-native * flow */ import React, { Component } from 'react'; import { AppRegistry, StyleSheet, View, ProgressBarAndroid } from 'react-native'; export default class AwesomeProject extends Component { render() { return ( <View style={styles.container}> <ProgressBarAndroid indeterminate={true} styleAttr="Horizontal"/> </View> ); } } const styles = StyleSheet.create({ container: { flex: 1 } }); AppRegistry.registerComponent('AwesomeProject', () => AwesomeProject); ``` Closes facebook#11791 Differential Revision: D4998602 Pulled By: davidaurelio fbshipit-source-id: e210684e2f2497238e4d3d0adf2754075be81e98
1 parent eb19904 commit f088bca

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Libraries/Components/ProgressBarAndroid/ProgressBarAndroid.android.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ var STYLE_ATTRIBUTES = [
2828
'LargeInverse',
2929
];
3030

31-
var indeterminateType = function(props, propName, componentName) {
31+
var indeterminateType = function(props, propName, componentName, ...rest) {
3232
var checker = function() {
3333
var indeterminate = props[propName];
3434
var styleAttr = props.styleAttr;
@@ -37,7 +37,7 @@ var indeterminateType = function(props, propName, componentName) {
3737
}
3838
};
3939

40-
return PropTypes.bool(props, propName, componentName) || checker();
40+
return PropTypes.bool(props, propName, componentName, ...rest) || checker();
4141
};
4242

4343
/**

0 commit comments

Comments
 (0)