Skip to content

Commit f3c8158

Browse files
jpshelleyfacebook-github-bot
authored andcommitted
Android - ReactNativeHost getUseDeveloperSupport to public
Summary: Currently React Native is opinionated in that the easiest approach is to extend ReactActivity. However to more easily allow integrating with existing application, we should allow some of the methods in ReactNativeHost to be public, and this is a very good first step. * There is no harm in making this public from what I can tell. * This allows `ReactNativeHost` to be more easily used outside of the `ReactActivity` and `ReactActivityDelegate` ecosystem. (A `ReactFragment` would be a good example) _No issues found_ **Test plan (required)** * Run any sample app and verify it still works. Make sure tests pass on both Travis and Circle CI. Closes facebook#11329 Differential Revision: D4287429 Pulled By: AaaChiuuu fbshipit-source-id: 8cb76f3226aae3737af5f5bd6010d3eea8df9bfe
1 parent 781480d commit f3c8158

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ReactAndroid/src/main/java/com/facebook/react/ReactNativeHost.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ protected String getJSMainModuleName() {
138138
/**
139139
* Returns whether dev mode should be enabled. This enables e.g. the dev menu.
140140
*/
141-
protected abstract boolean getUseDeveloperSupport();
141+
public abstract boolean getUseDeveloperSupport();
142142

143143
/**
144144
* Returns a list of {@link ReactPackage} used by the app.

0 commit comments

Comments
 (0)