Skip to content

Commit fffe2d0

Browse files
Brian Vaughnfacebook-github-bot
authored andcommitted
Update react-devtools-core to 3.6.3 to fix React Inspector
Summary: It appears that Electron (or the version of Chromium it uses) has a bug that causes a `webview` process to crash if `URL.createObjectURL` is used. Before releasing `react-devtools-core` 3.5.0, we updated Webpack and the loaders we used. Apparently the version of `style-loader` we now use makes use of the `URL.createObjectURL` API for CSS source maps. This triggers the `webview` crash I mentioned above. The fix for this is to disable CSS source maps, in which case the loader just uses a `<style>` tag. This diff updates Nuclide to pull in this fixed version. Reviewed By: bestander Differential Revision: D16518772 fbshipit-source-id: a779b7d310f869793fa05988d138ce6a46840d8c
1 parent 4a96918 commit fffe2d0

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@
107107
"pretty-format": "^24.7.0",
108108
"promise": "^7.1.1",
109109
"prop-types": "^15.7.2",
110-
"react-devtools-core": "^3.6.2",
110+
"react-devtools-core": "^3.6.3",
111111
"react-refresh": "^0.3.0",
112112
"regenerator-runtime": "^0.13.2",
113113
"scheduler": "0.14.0",

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5944,10 +5944,10 @@ react-deep-force-update@^1.0.0:
59445944
resolved "https://registry.yarnpkg.com/react-deep-force-update/-/react-deep-force-update-1.1.2.tgz#3d2ae45c2c9040cbb1772be52f8ea1ade6ca2ee1"
59455945
integrity sha512-WUSQJ4P/wWcusaH+zZmbECOk7H5N2pOIl0vzheeornkIMhu+qrNdGFm0bDZLCb0hSF0jf/kH1SgkNGfBdTc4wA==
59465946

5947-
react-devtools-core@^3.6.2:
5948-
version "3.6.2"
5949-
resolved "https://registry.yarnpkg.com/react-devtools-core/-/react-devtools-core-3.6.2.tgz#7d425f160c5928129fa9acdbdd9e80a334e09c8d"
5950-
integrity sha512-a5r2Er0PajtlvKYBUKzB3vW5qek8TbgQWwRruDEwTm3VnqVffHmnvApRil/lfkAa8ghXcESNizrtKu/18oG55Q==
5947+
react-devtools-core@^3.6.3:
5948+
version "3.6.3"
5949+
resolved "https://registry.yarnpkg.com/react-devtools-core/-/react-devtools-core-3.6.3.tgz#977d95b684c6ad28205f0c62e1e12c5f16675814"
5950+
integrity sha512-+P+eFy/yo8Z/UH9J0DqHZuUM5+RI2wl249TNvMx3J2jpUomLQa4Zxl56GEotGfw3PIP1eI+hVf1s53FlUONStQ==
59515951
dependencies:
59525952
shell-quote "^1.6.1"
59535953
ws "^3.3.1"

0 commit comments

Comments
 (0)