fix: onerror mem leak

dgeibi · dgeibi · commit 13bf4715bc98 · 2020-10-27T00:21:48.000+08:00
diff --git a/src/CssLoadingRuntimeModule.js b/src/CssLoadingRuntimeModule.js
@@ -60,8 +60,7 @@ module.exports = class CssLoadingRuntimeModule extends RuntimeModule {
           this.runtimeOptions.linkType
             ? `linkTag.type = ${JSON.stringify(this.runtimeOptions.linkType)};`
             : '',
-          'var onLinkComplete = function (event) {',
-          Template.indent([
+          `var onLinkComplete = ${runtimeTemplate.basicFunction('event', [
             '// avoid mem leaks.',
             'linkTag.onerror = linkTag.onload = null;',
             "if (event.type === 'load') {",
@@ -76,8 +75,7 @@ module.exports = class CssLoadingRuntimeModule extends RuntimeModule {
               'reject(err);',
             ]),
             '}',
-          ]),
-          '};',
+          ])}`,
           'linkTag.onerror = linkTag.onload = onLinkComplete;',
           'linkTag.href = fullhref;',
           crossOriginLoading
diff --git a/test/cases/hmr/expected/webpack-5/main.js b/test/cases/hmr/expected/webpack-5/main.js
@@ -827,7 +827,7 @@ module.exports = function (urlString) {
 /******/ 		
 /******/ 			linkTag.rel = "stylesheet";
 /******/ 			linkTag.type = "text/css";
-/******/ 			var onLinkComplete = function (event) {
+/******/ 			var onLinkComplete = (event) => {
 /******/ 				// avoid mem leaks.
 /******/ 				linkTag.onerror = linkTag.onload = null;
 /******/ 				if (event.type === 'load') {
@@ -840,7 +840,7 @@ module.exports = function (urlString) {
 /******/ 					linkTag.parentNode.removeChild(linkTag)
 /******/ 					reject(err);
 /******/ 				}
-/******/ 			};
+/******/ 			}
 /******/ 			linkTag.onerror = linkTag.onload = onLinkComplete;
 /******/ 			linkTag.href = fullhref;
 /******/ 		
diff --git a/test/cases/insert-function/expected/webpack-5/main.js b/test/cases/insert-function/expected/webpack-5/main.js
@@ -162,7 +162,7 @@
 /******/ 		
 /******/ 			linkTag.rel = "stylesheet";
 /******/ 			linkTag.type = "text/css";
-/******/ 			var onLinkComplete = function (event) {
+/******/ 			var onLinkComplete = (event) => {
 /******/ 				// avoid mem leaks.
 /******/ 				linkTag.onerror = linkTag.onload = null;
 /******/ 				if (event.type === 'load') {
@@ -175,7 +175,7 @@
 /******/ 					linkTag.parentNode.removeChild(linkTag)
 /******/ 					reject(err);
 /******/ 				}
-/******/ 			};
+/******/ 			}
 /******/ 			linkTag.onerror = linkTag.onload = onLinkComplete;
 /******/ 			linkTag.href = fullhref;
 /******/ 		
diff --git a/test/cases/insert-string/expected/webpack-5/main.js b/test/cases/insert-string/expected/webpack-5/main.js
@@ -162,7 +162,7 @@
 /******/ 		
 /******/ 			linkTag.rel = "stylesheet";
 /******/ 			linkTag.type = "text/css";
-/******/ 			var onLinkComplete = function (event) {
+/******/ 			var onLinkComplete = (event) => {
 /******/ 				// avoid mem leaks.
 /******/ 				linkTag.onerror = linkTag.onload = null;
 /******/ 				if (event.type === 'load') {
@@ -175,7 +175,7 @@
 /******/ 					linkTag.parentNode.removeChild(linkTag)
 /******/ 					reject(err);
 /******/ 				}
-/******/ 			};
+/******/ 			}
 /******/ 			linkTag.onerror = linkTag.onload = onLinkComplete;
 /******/ 			linkTag.href = fullhref;
 /******/ 		
diff --git a/test/cases/insert-undefined/expected/webpack-5/main.js b/test/cases/insert-undefined/expected/webpack-5/main.js
@@ -162,7 +162,7 @@
 /******/ 		
 /******/ 			linkTag.rel = "stylesheet";
 /******/ 			linkTag.type = "text/css";
-/******/ 			var onLinkComplete = function (event) {
+/******/ 			var onLinkComplete = (event) => {
 /******/ 				// avoid mem leaks.
 /******/ 				linkTag.onerror = linkTag.onload = null;
 /******/ 				if (event.type === 'load') {
@@ -175,7 +175,7 @@
 /******/ 					linkTag.parentNode.removeChild(linkTag)
 /******/ 					reject(err);
 /******/ 				}
-/******/ 			};
+/******/ 			}
 /******/ 			linkTag.onerror = linkTag.onload = onLinkComplete;
 /******/ 			linkTag.href = fullhref;
 /******/ 		
