Skip to content

Commit 2ad85fa

Browse files
committed
Fail no-ready rule when using arrow functions
Closes #35
1 parent df25692 commit 2ad85fa

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

rules/no-ready.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ function isDirect(node) {
88
node.callee.type === 'Identifier' &&
99
node.callee.name === '$' &&
1010
node.arguments[0] &&
11-
node.arguments[0].type === 'FunctionExpression'
11+
(node.arguments[0].type === 'FunctionExpression' ||
12+
node.arguments[0].type === 'ArrowFunctionExpression')
1213
)
1314
}
1415

tests/no-ready.js

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,11 @@ const RuleTester = require('eslint').RuleTester
55

66
const error = '$.ready is not allowed'
77

8-
const ruleTester = new RuleTester()
8+
const ruleTester = new RuleTester({parserOptions: {ecmaVersion: 6}})
99
ruleTester.run('no-ready', rule, {
1010
valid: [
1111
'ready(function() { })',
12+
'ready(() => { })',
1213
'ready()',
1314
'[].ready()',
1415
'div.ready()',
@@ -22,6 +23,10 @@ ruleTester.run('no-ready', rule, {
2223
code: '$(function() { })',
2324
errors: [{message: error, type: 'CallExpression'}]
2425
},
26+
{
27+
code: '$(() => { })',
28+
errors: [{message: error, type: 'CallExpression'}]
29+
},
2530
{
2631
code: '$(function init() { })',
2732
errors: [{message: error, type: 'CallExpression'}]
@@ -30,6 +35,10 @@ ruleTester.run('no-ready', rule, {
3035
code: '$(document).ready(function() { })',
3136
errors: [{message: error, type: 'CallExpression'}]
3237
},
38+
{
39+
code: '$(document).ready(() => { })',
40+
errors: [{message: error, type: 'CallExpression'}]
41+
},
3342
{
3443
code: '$().ready(function() { })',
3544
errors: [{message: error, type: 'CallExpression'}]

0 commit comments

Comments
 (0)