Skip to content

Commit 64bb736

Browse files
committed
Add rule for $.isFunction. RE: #19
1 parent 4b539a4 commit 64bb736

File tree

4 files changed

+37
-0
lines changed

4 files changed

+37
-0
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ Add `jquery` to the plugins section of your `.eslintrc` configuration file. You
4444
"jquery/no-fade": 2,
4545
"jquery/no-filter": 2,
4646
"jquery/no-find": 2,
47+
"jquery/no-function": 2,
4748
"jquery/no-global-eval": 2,
4849
"jquery/no-has": 2,
4950
"jquery/no-hide": 2,

index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ module.exports = {
1818
'no-fade': require('./rules/no-fade'),
1919
'no-filter': require('./rules/no-filter'),
2020
'no-find': require('./rules/no-find'),
21+
'no-function': require('./rules/no-function'),
2122
'no-global-eval': require('./rules/no-global-eval'),
2223
'no-has': require('./rules/no-has'),
2324
'no-hide': require('./rules/no-hide'),

rules/no-function.js

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
'use strict'
2+
3+
module.exports = function(context) {
4+
return {
5+
CallExpression: function(node) {
6+
if (node.callee.type !== 'MemberExpression') return
7+
if (node.callee.object.name !== '$') return
8+
if (node.callee.property.name !== 'isFunction') return
9+
10+
context.report({
11+
node: node,
12+
message: 'Prefer typeof to $.isFunction'
13+
})
14+
}
15+
}
16+
}
17+
18+
module.exports.schema = []

tests/no-function.js

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
'use strict'
2+
3+
const rule = require('../rules/no-function')
4+
const RuleTester = require('eslint').RuleTester
5+
6+
const error = 'Prefer typeof to $.isFunction'
7+
8+
const ruleTester = new RuleTester()
9+
ruleTester.run('no-function', rule, {
10+
valid: ['isFunction()', 'myClass.isFunction()'],
11+
invalid: [
12+
{
13+
code: '$.isFunction()',
14+
errors: [{message: error, type: 'CallExpression'}]
15+
}
16+
]
17+
})

0 commit comments

Comments
 (0)