Skip to content

Commit 796eb8d

Browse files
committed
Merge branch 'issue-19-add-is-function' of https://github.com/brendo/eslint-plugin-jquery into no-is-function
2 parents dd38592 + 9554ecb commit 796eb8d

File tree

4 files changed

+37
-0
lines changed

4 files changed

+37
-0
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ Add `jquery` to the plugins section of your `.eslintrc` configuration file. You
5151
"jquery/no-html": 2,
5252
"jquery/no-in-array": 2,
5353
"jquery/no-is-array": 2,
54+
"jquery/no-is-function": 2,
5455
"jquery/no-is": 2,
5556
"jquery/no-load": 2,
5657
"jquery/no-map": 2,

index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ module.exports = {
2525
'no-html': require('./rules/no-html'),
2626
'no-in-array': require('./rules/no-in-array'),
2727
'no-is-array': require('./rules/no-is-array'),
28+
'no-is-function': require('./rules/no-is-function'),
2829
'no-is': require('./rules/no-is'),
2930
'no-load': require('./rules/no-load'),
3031
'no-map': require('./rules/no-map'),

rules/no-is-function.js

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
'use strict'
2+
3+
module.exports = function(context) {
4+
return {
5+
CallExpression: function(node) {
6+
if (node.callee.type !== 'MemberExpression') return
7+
if (node.callee.object.name !== '$') return
8+
if (node.callee.property.name !== 'isFunction') return
9+
10+
context.report({
11+
node: node,
12+
message: 'Prefer typeof to $.isFunction'
13+
})
14+
}
15+
}
16+
}
17+
18+
module.exports.schema = []

tests/no-is-function.js

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
'use strict'
2+
3+
const rule = require('../rules/no-is-function')
4+
const RuleTester = require('eslint').RuleTester
5+
6+
const error = 'Prefer typeof to $.isFunction'
7+
8+
const ruleTester = new RuleTester()
9+
ruleTester.run('no-function', rule, {
10+
valid: ['isFunction()', 'myClass.isFunction()'],
11+
invalid: [
12+
{
13+
code: '$.isFunction()',
14+
errors: [{message: error, type: 'CallExpression'}]
15+
}
16+
]
17+
})

0 commit comments

Comments
 (0)