Skip to content

Commit 882d388

Browse files
committed
Add no-is-array rule
See #19
1 parent 4b539a4 commit 882d388

File tree

4 files changed

+37
-0
lines changed

4 files changed

+37
-0
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ Add `jquery` to the plugins section of your `.eslintrc` configuration file. You
4949
"jquery/no-hide": 2,
5050
"jquery/no-html": 2,
5151
"jquery/no-in-array": 2,
52+
"jquery/no-is-array": 2,
5253
"jquery/no-is": 2,
5354
"jquery/no-load": 2,
5455
"jquery/no-map": 2,

index.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ module.exports = {
2323
'no-hide': require('./rules/no-hide'),
2424
'no-html': require('./rules/no-html'),
2525
'no-in-array': require('./rules/no-in-array'),
26+
'no-is-array': require('./rules/no-is-array'),
2627
'no-is': require('./rules/no-is'),
2728
'no-load': require('./rules/no-load'),
2829
'no-map': require('./rules/no-map'),

rules/no-is-array.js

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
'use strict'
2+
3+
module.exports = function(context) {
4+
return {
5+
CallExpression: function(node) {
6+
if (node.callee.type !== 'MemberExpression') return
7+
if (node.callee.object.name !== '$') return
8+
if (node.callee.property.name !== 'isArray') return
9+
10+
context.report({
11+
node: node,
12+
message: 'Prefer Array#isArray to $.isArray'
13+
})
14+
}
15+
}
16+
}
17+
18+
module.exports.schema = []

tests/no-is-array.js

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
'use strict'
2+
3+
const rule = require('../rules/no-is-array')
4+
const RuleTester = require('eslint').RuleTester
5+
6+
const error = 'Prefer Array#isArray to $.isArray'
7+
8+
const ruleTester = new RuleTester()
9+
ruleTester.run('no-in-array', rule, {
10+
valid: ['isArray()', '"test".isArray()', '"test".isArray'],
11+
invalid: [
12+
{
13+
code: '$.isArray()',
14+
errors: [{message: error, type: 'CallExpression'}]
15+
}
16+
]
17+
})

0 commit comments

Comments
 (0)