Skip to content

Commit 961ea62

Browse files
committed
Merge branch 'grep'
2 parents 4b539a4 + 5d9b7dc commit 961ea62

File tree

4 files changed

+38
-0
lines changed

4 files changed

+38
-0
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ Add `jquery` to the plugins section of your `.eslintrc` configuration file. You
4545
"jquery/no-filter": 2,
4646
"jquery/no-find": 2,
4747
"jquery/no-global-eval": 2,
48+
"jquery/no-grep": 2,
4849
"jquery/no-has": 2,
4950
"jquery/no-hide": 2,
5051
"jquery/no-html": 2,

index.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ module.exports = {
1919
'no-filter': require('./rules/no-filter'),
2020
'no-find': require('./rules/no-find'),
2121
'no-global-eval': require('./rules/no-global-eval'),
22+
'no-grep': require('./rules/no-grep'),
2223
'no-has': require('./rules/no-has'),
2324
'no-hide': require('./rules/no-hide'),
2425
'no-html': require('./rules/no-html'),
@@ -68,6 +69,7 @@ module.exports = {
6869
'jquery/no-filter': 2,
6970
'jquery/no-find': 2,
7071
'jquery/no-global-eval': 2,
72+
'jquery/no-grep': 2,
7173
'jquery/no-has': 2,
7274
'jquery/no-hide': 2,
7375
'jquery/no-html': 2,

rules/no-grep.js

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
'use strict'
2+
3+
module.exports = function(context) {
4+
return {
5+
CallExpression: function(node) {
6+
if (node.callee.type !== 'MemberExpression') return
7+
if (node.callee.object.name !== '$') return
8+
if (node.callee.property.name !== 'grep') return
9+
10+
context.report({
11+
node: node,
12+
message: 'Prefer Array#filter to $.grep'
13+
})
14+
}
15+
}
16+
}
17+
18+
module.exports.schema = []

tests/no-grep.js

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
'use strict'
2+
3+
const rule = require('../rules/no-grep')
4+
const RuleTester = require('eslint').RuleTester
5+
6+
const error = 'Prefer Array#filter to $.grep'
7+
8+
const ruleTester = new RuleTester()
9+
ruleTester.run('no-in-array', rule, {
10+
valid: ['grep()', '"test".grep()', '"test".grep'],
11+
invalid: [
12+
{
13+
code: '$.grep()',
14+
errors: [{message: error, type: 'CallExpression'}]
15+
}
16+
]
17+
})

0 commit comments

Comments
 (0)