Skip to content

Commit 98c5fbf

Browse files
committed
Fix spacing issue on CC search guidelines page
1 parent f19a403 commit 98c5fbf

File tree

3 files changed

+17
-11
lines changed

3 files changed

+17
-11
lines changed

content/contributing-code/cc-search/contents.lr

+10-10
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ We also want to enable you - our community members - to build features that woul
1212

1313
If you do want to build a new feature, and we would love it if you did, all we ask is that you follow the process outlined in this document to ensure a smooth experience for everyone involved.
1414

15-
<h4 class="b-header has-text-grey">Step 0</h4>
15+
<h4 class="b-header has-text-grey is-marginless">Step 0</h4>
1616
### Evaluate Process
1717

1818
**Figure out if you need to follow this process.**
@@ -34,7 +34,7 @@ Examples that should follow this process:
3434
- Adding a new filter to the search results page
3535
- **Reasoning**: It is user facing and requires some product input and may require infrastructural work to collect the data that the search results will filter on.
3636

37-
<h4 class="b-header has-text-grey">Step 1</h4>
37+
<h4 class="b-header has-text-grey is-marginless">Step 1</h4>
3838
### GitHub Issue
3939

4040
**Describe the feature on GitHub.**
@@ -43,7 +43,7 @@ Look through [our issues](https://github.com/creativecommons/cccatalog-frontend/
4343

4444
On this GitHub issue, add a comment describing the feature you want to build and why you think it would be a good addition to CC Search. Add as much detail as you can.
4545

46-
<h4 class="b-header has-text-grey">Step 2</h4>
46+
<h4 class="b-header has-text-grey is-marginless">Step 2</h4>
4747
### CC Response
4848

4949
**Wait for a CC staff member to respond.**
@@ -58,7 +58,7 @@ If at any time it has been more than five business days and you haven't received
5858

5959
Once your feature has been preliminarily approved, proceed to Step 3.
6060

61-
<h4 class="b-header has-text-grey">Step 3</h4>
61+
<h4 class="b-header has-text-grey is-marginless">Step 3</h4>
6262
### Planning
6363

6464
**Plan your work.**
@@ -71,7 +71,7 @@ Once your implementation plan is ready, update the GitHub issue and wait for a s
7171

7272
Once your plan has been approved, proceed to the next applicable step.
7373

74-
<h4 class="b-header has-text-grey">Step 4</h4>
74+
<h4 class="b-header has-text-grey is-marginless">Step 4</h4>
7575
### Design
7676

7777
**Get Design and UX approved (if applicable).**
@@ -80,14 +80,14 @@ If your feature involves user-facing changes, please run these by us, either thr
8080

8181
Once your design has been approved, proceed to Step 5.
8282

83-
<h4 class="b-header has-text-grey">Step 5</h4>
83+
<h4 class="b-header has-text-grey is-marginless">Step 5</h4>
8484
### Dependencies
8585

8686
**Wait for CC staff to resolve dependencies (if applicable).**
8787

8888
If your feature depends on work that only CC staff can do, please wait for us to do that work. If you can start working on other parts of the feature in parallel, you may go ahead.
8989

90-
<h4 class="b-header has-text-grey">Step 6</h4>
90+
<h4 class="b-header has-text-grey is-marginless">Step 6</h4>
9191
### Code
9292

9393
**Write your code.**
@@ -96,7 +96,7 @@ At this point, CC staff and you should be on the same page about how the feature
9696

9797
Commit early and often, follow [our pull request and code guidelines](/contributing-code/pr-guidelines/), and write tests!
9898

99-
<h4 class="b-header has-text-grey">Step 7</h4>
99+
<h4 class="b-header has-text-grey is-marginless">Step 7</h4>
100100
### Code Review
101101

102102
**Get feedback via code review.**
@@ -105,14 +105,14 @@ Once your pull request is ready, someone on CC staff will review your code and p
105105

106106
You may have to do Steps 4-7 for multiple codebases in some cases, e.g. if your work includes both the CC Catalog API and CC Search, the API work will have to be done before the CC Search work that depends on it.
107107

108-
<h4 class="b-header has-text-grey">Step 8</h4>
108+
<h4 class="b-header has-text-grey is-marginless">Step 8</h4>
109109
### Staging
110110

111111
**Get feedback via live testing.**
112112

113113
Once your code is merged, it will be deployed to the staging server and tested manually (in addition to the comprehensive automated tests that you've already written). We may need to run some changes by our product counsel. This may produce an additional round of feedback for you to address.
114114

115-
<h4 class="b-header has-text-grey">Step 9</h4>
115+
<h4 class="b-header has-text-grey is-marginless">Step 9</h4>
116116
### Production
117117

118118
**The feature is live!**

themes/vocabulary_theme/templates/404.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{% extends "layout.html" %}
22
{% block body %}
3-
<div class="container padding-vertical-xxl has-text-centered page-not-found">
3+
<div class="container padding-vertical-xxl has-text-centered">
44
<h1>404</h1>
55
<h2>Page Not Found!</h2>
66
<p class="body-big">Sorry. The page you are looking for doesn't exist.</p>

webpack/sass/main.scss

+6
Original file line numberDiff line numberDiff line change
@@ -506,6 +506,12 @@ code {
506506
@extend .padding-horizontal-big;
507507
@extend .padding-top-xl;
508508
@extend .padding-bottom-xxl;
509+
510+
.content {
511+
h3 {
512+
margin-top: 0rem;
513+
}
514+
}
509515
}
510516
}
511517

0 commit comments

Comments
 (0)