Simplified the createPadding() method

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/cli/trunk@961361 13f79535-47bb-0310-9956-ffa450edef68

Author: ebourg

src/main/java/org/apache/commons/cli/HelpFormatter.java

@@ -19,6 +19,7 @@
 
 import java.io.PrintWriter;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.Comparator;
@@ -860,8 +861,7 @@ protected StringBuffer renderWrappedText(StringBuffer sb, int width,
             nextLineTabStop = 1;
         }
 
-        // all following lines must be padded with nextLineTabStop space 
-        // characters
+        // all following lines must be padded with nextLineTabStop space characters
         final String padding = createPadding(nextLineTabStop);
 
         while (true)
@@ -888,7 +888,7 @@ protected StringBuffer renderWrappedText(StringBuffer sb, int width,
     /**
      * Finds the next text wrap position after <code>startPos</code> for the
      * text in <code>text</code> with the column width <code>width</code>.
-     * The wrap point is the last postion before startPos+width having a 
+     * The wrap point is the last position before startPos+width having a 
      * whitespace character (space, \n, \r).
      *
      * @param text The text being searched for the wrap position
@@ -953,14 +953,10 @@ else if (startPos + width >= text.length())
      */
     protected String createPadding(int len)
     {
-        StringBuffer sb = new StringBuffer(len);
-
-        for (int i = 0; i < len; ++i)
-        {
-            sb.append(' ');
-        }
-
-        return sb.toString();
+        char[] padding = new char[len];
+        Arrays.fill(padding, ' ');
+        
+        return new String(padding);
     }
 
     /**