Ensure the consistency of the fields initial values in OptionBuilder before and after the creation of an option (fixes CLI-186)

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/cli/trunk@956302 13f79535-47bb-0310-9956-ffa450edef68

Author: ebourg

src/main/java/org/apache/commons/cli/OptionBuilder.java

@@ -57,6 +57,12 @@ public final class OptionBuilder
     /** option builder instance */
     private static OptionBuilder instance = new OptionBuilder();
 
+    static
+    {
+        // ensure the consistency of the initial values
+        reset();
+    }
+
     /**
      * private constructor to prevent instances being created
      */
@@ -76,9 +82,6 @@ private static void reset()
         type = null;
         required = false;
         numberOfArgs = Option.UNINITIALIZED;
-
-
-        // PMM 9/6/02 - these were missing
         optionalArg = false;
         valuesep = (char) 0;
     }