Fix checkstyle warnings, add suppressions for not possible changes due to bc.

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/cli/trunk@1439967 13f79535-47bb-0310-9956-ffa450edef68

Author: netomi

src/conf/checkstyle-suppressions.xml

@@ -4,7 +4,11 @@
 <suppressions>
 
   <!-- Suppress visibility check of some member fields as they have to be kept
-       for backwards compatibility reasons                                      -->
+       for binary compatibility reasons                                         -->
   <suppress checks="VisibilityModifier" files="HelpFormatter.java" />
 
+  <!-- Cannot hide public constructor due to binary compatibility reasons       -->
+  <suppress checks="HideUtilityClassConstructor" files="PatternOptionBuilder.java" />
+  <suppress checks="HideUtilityClassConstructor" files="TypeHandler.java" />
+
 </suppressions>

src/conf/checkstyle.xml

@@ -98,7 +98,7 @@ limitations under the License.
         </module>
         <module name="MethodLength"/>
         <module name="ParameterNumber">
-            <property name="max" value="8"/>
+            <property name="max" value="9"/>
         </module>
 
 

src/main/java/org/apache/commons/cli/OptionValidator.java

@@ -24,7 +24,7 @@
  * @version $Revision$, $Date$
  * @since 1.1
  */
-class OptionValidator
+final class OptionValidator
 {
     /**
      * Hide constructor for a utility class.

src/main/java/org/apache/commons/cli/Util.java

@@ -23,7 +23,7 @@
  * @author John Keyes (john at integralsource.com)
  * @version $Revision$, $Date$
  */
-class Util
+final class Util
 {
     /**
      * Hide constructor for a utility class.