Skip to content

Commit 0fabf93

Browse files
committed
Fix #565 -- Replace render with render_to_response.
1 parent d2f5e4b commit 0fabf93

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

debug_toolbar/panels/sql/views.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from __future__ import absolute_import, unicode_literals
22

33
from django.http import HttpResponseBadRequest
4-
from django.shortcuts import render
4+
from django.shortcuts import render_to_response
55
from django.views.decorators.csrf import csrf_exempt
66

77
from debug_toolbar.panels.sql.forms import SQLSelectForm
@@ -27,7 +27,8 @@ def sql_select(request):
2727
'headers': headers,
2828
'alias': form.cleaned_data['alias'],
2929
}
30-
return render(request, 'debug_toolbar/panels/sql_select.html', context)
30+
# Using render_to_response avoids running global context processors.
31+
return render_to_response('debug_toolbar/panels/sql_select.html', context)
3132
return HttpResponseBadRequest('Form errors')
3233

3334

@@ -62,7 +63,8 @@ def sql_explain(request):
6263
'headers': headers,
6364
'alias': form.cleaned_data['alias'],
6465
}
65-
return render(request, 'debug_toolbar/panels/sql_explain.html', context)
66+
# Using render_to_response avoids running global context processors.
67+
return render_to_response('debug_toolbar/panels/sql_explain.html', context)
6668
return HttpResponseBadRequest('Form errors')
6769

6870

@@ -107,5 +109,6 @@ def sql_profile(request):
107109
'headers': headers,
108110
'alias': form.cleaned_data['alias'],
109111
}
110-
return render(request, 'debug_toolbar/panels/sql_profile.html', context)
112+
# Using render_to_response avoids running global context processors.
113+
return render_to_response('debug_toolbar/panels/sql_profile.html', context)
111114
return HttpResponseBadRequest('Form errors')

debug_toolbar/panels/templates/views.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
from django.http import HttpResponseBadRequest
44
from django.conf import settings
5-
from django.shortcuts import render
5+
from django.shortcuts import render_to_response
66
from django.template import TemplateDoesNotExist
77
from django.template.loader import find_template_loader
88
from django.utils.safestring import mark_safe
@@ -40,7 +40,8 @@ def template_source(request):
4040
except ImportError:
4141
pass
4242

43-
return render(request, 'debug_toolbar/panels/template_source.html', {
43+
# Using render_to_response avoids running global context processors.
44+
return render_to_response('debug_toolbar/panels/template_source.html', {
4445
'source': source,
4546
'template_name': template_name
4647
})

0 commit comments

Comments
 (0)