Skip to content

Commit 37bdad5

Browse files
committed
Make system checks tests pass on Django@master again
1 parent 5b279ba commit 37bdad5

File tree

1 file changed

+17
-11
lines changed

1 file changed

+17
-11
lines changed

tests/test_integration.py

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -339,8 +339,9 @@ def test_django_cached_template_loader(self):
339339
@override_settings(DEBUG=True)
340340
class DebugToolbarSystemChecksTestCase(BaseTestCase):
341341
@override_settings(
342-
MIDDLEWARE=None,
343-
MIDDLEWARE_CLASSES=[
342+
MIDDLEWARE=[
343+
'django.contrib.messages.middleware.MessageMiddleware',
344+
'django.contrib.auth.middleware.AuthenticationMiddleware',
344345
'django.middleware.gzip.GZipMiddleware',
345346
'debug_toolbar.middleware.DebugToolbarMiddleware',
346347
]
@@ -349,24 +350,28 @@ def test_check_good_configuration(self):
349350
messages = run_checks()
350351
self.assertEqual(messages, [])
351352

352-
@override_settings(MIDDLEWARE=None, MIDDLEWARE_CLASSES=[])
353+
@override_settings(MIDDLEWARE=[
354+
'django.contrib.messages.middleware.MessageMiddleware',
355+
'django.contrib.auth.middleware.AuthenticationMiddleware',
356+
])
353357
def test_check_missing_middleware_error(self):
354358
messages = run_checks()
355359
self.assertEqual(
356360
messages,
357361
[
358362
Error(
359363
"debug_toolbar.middleware.DebugToolbarMiddleware is "
360-
"missing from MIDDLEWARE_CLASSES.",
364+
"missing from MIDDLEWARE.",
361365
hint="Add debug_toolbar.middleware.DebugToolbarMiddleware "
362-
"to MIDDLEWARE_CLASSES.",
366+
"to MIDDLEWARE.",
363367
),
364368
]
365369
)
366370

367371
@override_settings(
368-
MIDDLEWARE=None,
369-
MIDDLEWARE_CLASSES=[
372+
MIDDLEWARE=[
373+
'django.contrib.messages.middleware.MessageMiddleware',
374+
'django.contrib.auth.middleware.AuthenticationMiddleware',
370375
'debug_toolbar.middleware.DebugToolbarMiddleware',
371376
'django.middleware.gzip.GZipMiddleware',
372377
]
@@ -379,20 +384,21 @@ def test_check_gzip_middleware_error(self):
379384
Error(
380385
"debug_toolbar.middleware.DebugToolbarMiddleware occurs "
381386
"before django.middleware.gzip.GZipMiddleware in "
382-
"MIDDLEWARE_CLASSES.",
387+
"MIDDLEWARE.",
383388
hint="Move debug_toolbar.middleware.DebugToolbarMiddleware "
384389
"to after django.middleware.gzip.GZipMiddleware in "
385-
"MIDDLEWARE_CLASSES.",
390+
"MIDDLEWARE.",
386391
),
387392
]
388393
)
389394

390395
@override_settings(
391396
MIDDLEWARE=[
397+
'django.contrib.messages.middleware.MessageMiddleware',
398+
'django.contrib.auth.middleware.AuthenticationMiddleware',
392399
'debug_toolbar.middleware.DebugToolbarMiddleware',
393400
'tests.middleware.simple_middleware',
394-
],
395-
MIDDLEWARE_CLASSES=None
401+
]
396402
)
397403
def test_middleware_factory_functions_supported(self):
398404
messages = run_checks()

0 commit comments

Comments
 (0)