Skip to content

Commit 39f284d

Browse files
authored
Merge pull request #840 from timgraham/old-python-cleanup
Dropped a branch for Python < 2.7 compatibility.
2 parents e610183 + 3823ead commit 39f284d

File tree

4 files changed

+4
-14
lines changed

4 files changed

+4
-14
lines changed

debug_toolbar/compat.py

-1
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,3 @@
99
from django.template.base import linebreak_iter # NOQA
1010
except ImportError: # Django < 1.9
1111
from django.views.debug import linebreak_iter # NOQA
12-

debug_toolbar/middleware.py

+2-9
Original file line numberDiff line numberDiff line change
@@ -112,15 +112,8 @@ def process_response(self, request, response):
112112
# Insert the toolbar in the response.
113113
content = force_text(response.content, encoding=settings.DEFAULT_CHARSET)
114114
insert_before = dt_settings.get_config()['INSERT_BEFORE']
115-
try: # Python >= 2.7
116-
pattern = re.escape(insert_before)
117-
bits = re.split(pattern, content, flags=re.IGNORECASE)
118-
except TypeError: # Python < 2.7
119-
pattern = '(.+?)(%s|$)' % re.escape(insert_before)
120-
matches = re.findall(pattern, content, flags=re.DOTALL | re.IGNORECASE)
121-
bits = [m[0] for m in matches if m[1] == insert_before]
122-
# When the body ends with a newline, there's two trailing groups.
123-
bits.append(''.join(m[0] for m in matches if m[1] == ''))
115+
pattern = re.escape(insert_before)
116+
bits = re.split(pattern, content, flags=re.IGNORECASE)
124117
if len(bits) > 1:
125118
# When the toolbar will be inserted for sure, generate the stats.
126119
for panel in reversed(toolbar.enabled_panels):

debug_toolbar/panels/templates/panel.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,10 @@
55
from os.path import normpath
66
from pprint import pformat
77

8-
import django
98
from django import http
109
from django.conf.urls import url
1110
from django.db.models.query import QuerySet, RawQuerySet
12-
from django.template import Context, RequestContext, Template
11+
from django.template import RequestContext, Template
1312
from django.test.signals import template_rendered
1413
from django.test.utils import instrumented_test_render
1514
from django.utils import six

debug_toolbar/panels/templates/views.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@
33
from django.http import HttpResponseBadRequest
44
from django.shortcuts import render_to_response
55
from django.template import TemplateDoesNotExist
6-
from django.utils.safestring import mark_safe
7-
86
from django.template.engine import Engine
7+
from django.utils.safestring import mark_safe
98

109

1110
def template_source(request):

0 commit comments

Comments
 (0)