Skip to content

Commit 3b28475

Browse files
committed
Merge pull request #350 from charettes/simplejson
Use the built-in json module on python >= 2.6.
2 parents 22ebebd + d497160 commit 3b28475

File tree

2 files changed

+16
-8
lines changed

2 files changed

+16
-8
lines changed

debug_toolbar/utils/tracking/db.py

+7-3
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,20 @@
55

66
from django.conf import settings
77
from django.template import Node
8-
from django.utils import simplejson
98
from django.utils.encoding import force_unicode, smart_str
109

1110
from debug_toolbar.utils import ms_from_timedelta, tidy_stacktrace, \
1211
get_template_info, get_stack
1312
from debug_toolbar.utils.compat.db import connections
1413

14+
try:
15+
import json
16+
except ImportError: # python < 2.6
17+
from django.utils import simplejson as json
18+
1519
try:
1620
from hashlib import sha1
17-
except ImportError:
21+
except ImportError: # python < 2.5
1822
from django.utils.hashcompat import sha_constructor as sha1
1923

2024
# TODO:This should be set in the toolbar loader as a default and panels should
@@ -103,7 +107,7 @@ def execute(self, sql, params=()):
103107
stacktrace = []
104108
_params = ''
105109
try:
106-
_params = simplejson.dumps(
110+
_params = json.dumps(
107111
[force_unicode(x, strings_only=True) for x in params]
108112
)
109113
except TypeError:

debug_toolbar/views.py

+9-5
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,17 @@
99
from django.conf import settings
1010
from django.http import HttpResponseBadRequest
1111
from django.shortcuts import render_to_response
12-
from django.utils import simplejson
1312

1413
from debug_toolbar.utils.compat.db import connections
1514

15+
try:
16+
import json
17+
except ImportError: # python < 2.6
18+
from django.utils import simplejson as json
19+
1620
try:
1721
from hashlib import sha1
18-
except ImportError:
22+
except ImportError: # python < 2.5
1923
from django.utils.hashcompat import sha_constructor as sha1
2024

2125

@@ -45,7 +49,7 @@ def sql_select(request):
4549
if hash != request.GET.get('hash', ''):
4650
return HttpResponseBadRequest('Tamper alert') # SQL Tampering alert
4751
if sql.lower().strip().startswith('select'):
48-
params = simplejson.loads(params)
52+
params = json.loads(params)
4953
cursor = connections[alias].cursor()
5054
cursor.execute(sql, params)
5155
headers = [d[0] for d in cursor.description]
@@ -80,7 +84,7 @@ def sql_explain(request):
8084
if hash != request.GET.get('hash', ''):
8185
return HttpResponseBadRequest('Tamper alert') # SQL Tampering alert
8286
if sql.lower().strip().startswith('select'):
83-
params = simplejson.loads(params)
87+
params = json.loads(params)
8488
cursor = connections[alias].cursor()
8589

8690
conn = connections[alias].connection
@@ -126,7 +130,7 @@ def sql_profile(request):
126130
if hash != request.GET.get('hash', ''):
127131
return HttpResponseBadRequest('Tamper alert') # SQL Tampering alert
128132
if sql.lower().strip().startswith('select'):
129-
params = simplejson.loads(params)
133+
params = json.loads(params)
130134
cursor = connections[alias].cursor()
131135
result = None
132136
headers = None

0 commit comments

Comments
 (0)