Skip to content

Commit 3d34754

Browse files
authored
Merge branch 'master' into eqeqeq
2 parents e5dc959 + 2dfbb28 commit 3d34754

File tree

2 files changed

+7
-31
lines changed

2 files changed

+7
-31
lines changed

debug_toolbar/static/debug_toolbar/js/toolbar.js

Lines changed: 1 addition & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
}
2323
},
2424
visible: function(element) {
25-
style = getComputedStyle(element);
25+
var style = getComputedStyle(element);
2626
return style.display !== 'none';
2727
},
2828
executeScripts: function(root) {
@@ -56,10 +56,6 @@
5656

5757
var djdt = {
5858
handleDragged: false,
59-
events: {
60-
ready: []
61-
},
62-
isReady: false,
6359
init: function() {
6460
var djDebug = document.querySelector('#djDebug');
6561
$$.show(djDebug);
@@ -138,9 +134,6 @@
138134
var self = this;
139135
var id = this.dataset.toggleId;
140136
var open_me = this.textContent === this.dataset.toggleOpen;
141-
if (id === '' || !id) {
142-
return;
143-
}
144137
var name = this.dataset.toggleName;
145138
var container = this.closest('.djDebugPanelContent').querySelector('#' + name + '_' + id);
146139
container.querySelectorAll('.djDebugCollapsed').forEach(function(e) {
@@ -217,10 +210,6 @@
217210
} else {
218211
djdt.show_toolbar();
219212
}
220-
djdt.isReady = true;
221-
djdt.events.ready.forEach(function(callback) {
222-
callback(djdt);
223-
});
224213
},
225214
hide_panels: function() {
226215
var djDebug = document.getElementBy('djDebug');
@@ -276,13 +265,6 @@
276265
expires: 10
277266
});
278267
},
279-
ready: function(callback){
280-
if (djdt.isReady) {
281-
callback(djdt);
282-
} else {
283-
djdt.events.ready.push(callback);
284-
}
285-
},
286268
cookie: {
287269
get: function(key){
288270
if (document.cookie.indexOf(key) === -1) return null;

debug_toolbar/static/debug_toolbar/js/toolbar.timer.js

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,12 @@
11
(function () {
2-
// Browser timing remains hidden unless we can successfully access the performance object
3-
var perf = window.performance || window.msPerformance ||
4-
window.webkitPerformance || window.mozPerformance;
5-
if (!perf)
6-
return;
7-
8-
var timingOffset = perf.timing.navigationStart,
9-
timingEnd = perf.timing.loadEventEnd,
2+
var timingOffset = performance.timing.navigationStart,
3+
timingEnd = performance.timing.loadEventEnd,
104
totalTime = timingEnd - timingOffset;
115
function getLeft(stat) {
12-
return ((perf.timing[stat] - timingOffset) / (totalTime)) * 100.0;
6+
return ((performance.timing[stat] - timingOffset) / (totalTime)) * 100.0;
137
}
148
function getCSSWidth(stat, endStat) {
15-
var width = ((perf.timing[endStat] - perf.timing[stat]) / (totalTime)) * 100.0;
9+
var width = ((performance.timing[endStat] - performance.timing[stat]) / (totalTime)) * 100.0;
1610
// Calculate relative percent (same as sql panel logic)
1711
width = 100.0 * width / (100.0 - getLeft(stat));
1812
return (width < 1) ? "2px" : width + "%";
@@ -23,13 +17,13 @@
2317
// Render a start through end bar
2418
row.innerHTML = '<td>' + stat.replace('Start', '') + '</td>' +
2519
'<td class="djdt-timeline"><div class="djDebugTimeline"><div class="djDebugLineChart"><strong>&#160;</strong></div></div></td>' +
26-
'<td>' + (perf.timing[stat] - timingOffset) + ' (+' + (perf.timing[endStat] - perf.timing[stat]) + ')</td>';
20+
'<td>' + (performance.timing[stat] - timingOffset) + ' (+' + (performance.timing[endStat] - performance.timing[stat]) + ')</td>';
2721
row.querySelector('strong').style.width = getCSSWidth(stat, endStat);
2822
} else {
2923
// Render a point in time
3024
row.innerHTML = '<td>' + stat + '</td>' +
3125
'<td class="djdt-timeline"><div class="djDebugTimeline"><div class="djDebugLineChart"><strong>&#160;</strong></div></div></td>' +
32-
'<td>' + (perf.timing[stat] - timingOffset) + '</td>';
26+
'<td>' + (performance.timing[stat] - timingOffset) + '</td>';
3327
row.querySelector('strong').style.width = '2px';
3428
}
3529
row.querySelector('.djDebugLineChart').style.left = getLeft(stat) + '%';

0 commit comments

Comments
 (0)